[core] Use the root dependency#3425
Merged
oliviertassinari merged 1 commit intomui:masterfrom Apr 20, 2024
Merged
Conversation
oliviertassinari
added
the
internal
oliviertassinari
force-pushed
the
simplify-dependencies
branch
from
c6a2393 to
124d7a0
Compare
Janpot
approved these changes
Apr 20, 2024
Member
Janpot
left a comment
Janpot
left a comment
There was a problem hiding this comment.
This was a hack that solved some issues we had with dependency hoisting under yarn. If it works now, I'm fine with it.
Member
Author
|
Right, this duplication has been here since the beginning: #542. The CI is green, looks like we are good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that we don't need this, it duplicates the root, and makes it possible to have a separate version of the mono repo (not helping to move the codebase all at once).