Skip to content

Update MUI package versions to v7 in Toolpad Core#4746

Closed
apedroferreira wants to merge 10 commits intomui:masterfrom
apedroferreira:update-mui-7
Closed

Update MUI package versions to v7 in Toolpad Core#4746
apedroferreira wants to merge 10 commits intomui:masterfrom
apedroferreira:update-mui-7

Conversation

@apedroferreira
Copy link
Collaborator

@apedroferreira apedroferreira commented Mar 10, 2025

On top of #4745

These updates should be needed? I can't commit directly to #4745

@apedroferreira apedroferreira added the internal Behind-the-scenes enhancement. Formerly called “core”. label Mar 10, 2025
@apedroferreira apedroferreira self-assigned this Mar 10, 2025
@mui-bot
Copy link

mui-bot commented Mar 10, 2025

Netlify deploy preview

https://deploy-preview-4746--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 22156c2

@apedroferreira apedroferreira changed the title Update MUI package versions to v7 Update MUI package versions to v7 in Toolpad Core Mar 10, 2025
@apedroferreira
Copy link
Collaborator Author

apedroferreira commented Mar 10, 2025

A few issues I've found due to these recent changes but couldn't find the best fix for:

  • dev command fails when it uses build-types --watch as the updated builtTypes script does not seem to be able to take those flags anymore
  • toolpad-studio-components seems to have issues importing from @toolpad/utils
  • I was trying to debug Toolpad Studio to make sure nothing broke there, but it throws errors when importing icons when you run the app, might also be related to these changes

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 11, 2025
@Janpot
Copy link
Member

Janpot commented Mar 11, 2025

I'm reverting #4745 until X pushes their beta, so that we can release

@prakhargupta1 prakhargupta1 linked an issue Mar 12, 2025 that may be closed by this pull request
@apedroferreira apedroferreira deleted the update-mui-7 branch April 1, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. PR: out-of-date The pull request has merge conflicts and can't be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add core v7 alpha as peer dependencies

3 participants