properly implemented Accept-Encoding:gzip. gzip availability is checked runtime. #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 9, 2020 15:43
ziyan
approved these changes
May 2, 2022
Contributor
Author
|
incremented patch after @ziyan 's approval. should not need to increment minor as header is the same. |
Contributor
Author
|
@kanbouchou I think this is the time to revisit this. |
woswos
approved these changes
Feb 3, 2026
Contributor
Author
|
I tested that Accept-Encoding is added with stock libcurl and not added with custom libcurl CURL_ZLIB=OFF, using the same libmujincontrollerclientcpp. |
added 2 commits
February 4, 2026 16:17
Contributor
Author
|
let me run the last sanity check https://tiny.mujin.co.jp/ln7r9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #74
previously gzip is enabled always, so incompatible windows binary needed to be replaced. This version enables gzip only when libcurl says it implements it.
tested on Win10/VS2010