Add MD4,MD5; add warning about obsolete hash functions#76
Merged
daviddias merged 5 commits intomultiformats:masterfrom Sep 4, 2017
Merged
Add MD4,MD5; add warning about obsolete hash functions#76daviddias merged 5 commits intomultiformats:masterfrom
daviddias merged 5 commits intomultiformats:masterfrom
Conversation
Contributor
Author
|
@jbenet could you please look this over? I'm actually in need of this functionality. |
|
I think these codes look good to me, what do you think @diasdavid @whyrusleeping @celeduc could you also add these to the csv in multicodec? That one is the canonical table and multihash is just a subset. I dislike the duplication too, PRs very welcome :) |
Member
|
Seems that there is no collision with https://github.com/multiformats/multicodec/blob/master/table.csv, as @lgierth said, we prefer to have the codecs first merged at the multicodec table then on the specs that dependent on it, so once we have that, we are golden to merge all of them PRs :) |
Contributor
Author
|
I submitted PR #41 to multicodec, where it's held with a comment by @Kubuxu |
Contributor
Author
|
Ready for merge! |
daviddias
approved these changes
Sep 4, 2017
Member
|
thank you @celeduc :) |
This was referenced Sep 4, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #71 by adding MD4 and MD5 to the list of supported hash functions.
Adds a note to the README cautioning about their use.