Skip to content

Post-release v1.3.0 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BakerNet merged 1 commit into from
Jul 3, 2025
+2 −2
Merged

Post-release v1.3.0 #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
fetch-depth: 0

- name: 'Codeowners Plus'
uses: multimediallc/codeowners-plus@v1.1.1
uses: multimediallc/codeowners-plus@v1.3.0
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a version tag like @v1.3.0 is common, but for improved security and reproducible builds, it's a best practice to pin actions to a specific commit SHA. Tags are mutable and can be moved, which could lead to your workflow unexpectedly running different code. Using the full-length commit SHA of the v1.3.0 release would make this example more robust and secure against potential supply chain issues.

with:
github-token: '${{ secrets.GITHUB_TOKEN }}'
pr: '${{ github.event.pull_request.number }}'
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func main() {
app := &cli.App{
Name: "codeowners-cli",
Usage: "CLI tool for working with .codeowners files",
Version: "v1.1.2.dev",
Version: "v1.3.1.dev",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding the version string here can be brittle and easy to forget to update. For better maintainability, consider setting the version at build time using linker flags (-ldflags). This would involve declaring a package-level version variable and then assigning it here (e.g., Version: version). This approach decouples the version string from the source code and makes it easier to automate version bumps during your release process.

Description: "",
Commands: []*cli.Command{
{
Expand Down
Loading