Skip to content

v1.5.0 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BakerNet merged 1 commit into from
Oct 6, 2025
Merged

v1.5.0 #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
fetch-depth: 0

- name: 'Codeowners Plus'
uses: multimediallc/codeowners-plus@v1.3.2
uses: multimediallc/codeowners-plus@v1.5.0
with:
github-token: '${{ secrets.GITHUB_TOKEN }}'
pr: '${{ github.event.pull_request.number }}'
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func main() {
app := &cli.App{
Name: "codeowners-cli",
Usage: "CLI tool for working with .codeowners files",
Version: "v1.3.3.dev",
Version: "v1.5.1.dev",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PR appears to be for the v1.5.0 release. Setting the CLI version to v1.5.1.dev in this PR means that the binary built from the v1.5.0 tag will report its version as v1.5.1.dev, which could be confusing for users.

A common practice is to set the version to the actual release number in the release commit. A follow-up PR can then bump it to the next development version. I'd suggest setting the version to v1.5.0 here.

Suggested change
Version: "v1.5.1.dev",
Version: "v1.5.0",

Description: "",
Commands: []*cli.Command{
{
Expand Down