Add directional edge markers and control toggle#133
Merged
Conversation
waxlamp
previously approved these changes
Dec 16, 2020
Contributor
waxlamp
left a comment
waxlamp
left a comment
There was a problem hiding this comment.
This is certainly a good start, but there are better (but more complicated) ways to indicate edge directionality with less clutter when lots of edges intersect.
Let's get some design feedback from Jared and Alex/Miriah.
JackWilb
force-pushed
the
directional-edges
branch
from
51c2840 to
51b9258
Compare
Member
Author
|
Force pushed because the branch this came from was interactive rebased. I had to remove some commits that were no longer in the base branch |
waxlamp
approved these changes
Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #122 (since the type definition moved to types.ts from store/index.ts)
Closes #129
Is a first step towards #131
This adds a text path element onto the link by using an href and then moves the arrow along the path using an offset. I also added another switch for the control in the control panel. There was a type that needed to be updated,
State, and I enabled a new getter and setter in the store for thedirectionalEdgesvariable. I also cleaned out some old CSS that was no longer needed.Here's the relevant MDN docs for textPath and here is the documentation for startOffset