Use D3 on tick to set the position of the nodes back to the SVG#325
Merged
Use D3 on tick to set the position of the nodes back to the SVG#325
Conversation
✅ Deploy Preview for next-multilink ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #136
Give a longer description of what this PR addresses and why it's needed
This uses the
on('tick')logic to set the node back to the SVG instead of using a helper method to hide the true value of thenode.xandnode.yvalues.Additionally, I updated an eslint rule here so we don't have to ignore
param-reassignwhen mutating the props of a parameter.Provide pictures/videos of the behavior before and after these changes (optional)
N/A
Are there any additional TODOs before this PR is ready to go?