Skip to content

Redo trrack#342

Merged
JackWilb merged 19 commits intomainfrom
redo-trrack
Feb 3, 2023
Merged

Redo trrack#342
JackWilb merged 19 commits intomainfrom
redo-trrack

Conversation

@JackWilb
Copy link
Copy Markdown
Member

@JackWilb JackWilb commented Jan 3, 2023

Does this PR close any open issues?

Closes #137
Closes #162
Closes #227

Give a longer description of what this PR addresses and why it's needed

This PR moves the track code from the main store file to its own file. Then the provenance is imported into the main store and you can access it from the components like normal. This is a huge simplifier, and we can keep all the logic local to the provenance code.

Provide pictures/videos of the behavior before and after these changes (optional)

Are there any additional TODOs before this PR is ready to go?

TODOs:

  • Add more items to the store
  • Figure out how to update provenance with sliders (we don't want every update to the value, just the final update)
  • Remove peer dependencies when Kiran fixes the packaging
  • Add back track-vis

@JackWilb JackWilb marked this pull request as draft January 3, 2023 19:12
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 3, 2023

Deploy Preview for next-multilink ready!

Name Link
🔨 Latest commit 86e282d
🔍 Latest deploy log https://app.netlify.com/sites/next-multilink/deploys/63dd489a0c958c0008d60ab7
😎 Deploy Preview https://deploy-preview-342--next-multilink.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JackWilb JackWilb mentioned this pull request Jan 9, 2023
1 task
@JackWilb JackWilb marked this pull request as ready for review February 3, 2023 17:47
@JackWilb JackWilb merged commit 789b650 into main Feb 3, 2023
@JackWilb JackWilb deleted the redo-trrack branch February 3, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant