Conversation
JackWilb
changed the title
starred field to Sessions and Workspaces, starred sessions are now readonly (state PUT does not work)starred field to Sessions and Workspaces, starred sessions are now readonly (state PUT does not work on them)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Helps towards multinet-app/multinet-client#285
Give a longer description of what this PR addresses and why it's needed
This adds the notion of starring to the workspaces and sessions. Starring is a boolean flag that can only be set through the admin panel and will allow us to move starred workspaces and sessions to the top of their respective areas. Starred sessions have a readonly state and will throw an error when a user tries to submit a PUT to the session state. This means we could ultimately change the session through the admin panel, but not the API route.
Provide pictures/videos of the behavior before and after these changes (optional)
N/A
Are there any additional TODOs before this PR is ready to go?
TODOs: