-
Notifications
You must be signed in to change notification settings - Fork 3
Address various papercuts in the UI/UX #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2a70653
463f586
453967c
4d3c07d
e0e17f6
9785d05
fdcf721
59c6472
900991e
3519592
8d68860
e3a1b89
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| <template> | ||
| <v-menu | ||
| v-model="actionsMenu" | ||
| max-width="275" | ||
| offset-y | ||
| origin="center center" | ||
| transition="scale-transition" | ||
| > | ||
| <template v-slot:activator="{ on }"> | ||
| <v-btn | ||
| icon | ||
| v-on="on" | ||
| > | ||
| <v-icon>more_vert</v-icon> | ||
| </v-btn> | ||
| </template> | ||
| <v-card> | ||
| <v-list | ||
| dense | ||
| width="224" | ||
| > | ||
| <!-- Each listing here should contain a v-list-item --> | ||
| <PermissionsDialog :workspace="workspace" /> | ||
| <v-list-item :to="{ name: 'aqlWizard' }"> | ||
| <v-list-item-icon class="mr-3"> | ||
| <v-icon>search</v-icon> | ||
| </v-list-item-icon> | ||
| <v-list-item-content> | ||
| AQL Wizard | ||
| </v-list-item-content> | ||
| </v-list-item> | ||
| </v-list> | ||
| </v-card> | ||
| </v-menu> | ||
| </template> | ||
|
|
||
| <script lang="ts"> | ||
| import { defineComponent, PropType, ref } from '@vue/composition-api'; | ||
| import PermissionsDialog from '@/components/PermissionsDialog.vue'; | ||
|
|
||
| export default defineComponent({ | ||
| components: { | ||
| PermissionsDialog, | ||
| }, | ||
|
|
||
| props: { | ||
| workspace: { | ||
| type: String as PropType<string>, | ||
| required: true, | ||
| }, | ||
| }, | ||
|
|
||
| setup() { | ||
| const actionsMenu = ref(false); | ||
|
|
||
| return { | ||
| actionsMenu, | ||
| }; | ||
| }, | ||
| }); | ||
| </script> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,23 +37,30 @@ const { | |
| currentWorkspacePermission: null, | ||
| } as State, | ||
| getters: { | ||
| tables(state: State, getters): string[] { | ||
| if (state.currentWorkspace !== null && state.currentWorkspace.nodeTables && state.currentWorkspace.edgeTables) { | ||
| return getters.nodeTables.concat(getters.edgeTables).sort(); | ||
| } | ||
| return []; | ||
|
Comment on lines
+40
to
+44
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What problem does it solve to alphabetize all the tables? There's an argument that the tables should appear in order of newness (though I'm not sure that's what happens currently), but alphabetic is a fine default choice too. More generally, we ought to be able to change the sort order on the fly. Would you mind filing an issue to that effect?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See #207
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was still curious why you wanted to see tables alphabetized. |
||
| }, | ||
|
|
||
| nodeTables(state: State): string[] { | ||
| if (state.currentWorkspace !== null && state.currentWorkspace.nodeTables) { | ||
| return state.currentWorkspace.nodeTables; | ||
| return state.currentWorkspace.nodeTables.sort(); | ||
| } | ||
| return []; | ||
| }, | ||
|
|
||
| edgeTables(state: State): string[] { | ||
| if (state.currentWorkspace !== null && state.currentWorkspace.edgeTables) { | ||
| return state.currentWorkspace.edgeTables; | ||
| return state.currentWorkspace.edgeTables.sort(); | ||
| } | ||
| return []; | ||
| }, | ||
|
|
||
| networks(state: State) { | ||
| if (state.currentWorkspace !== null && state.currentWorkspace.networks) { | ||
| return state.currentWorkspace.networks; | ||
| return state.currentWorkspace.networks.sort(); | ||
| } | ||
| return []; | ||
| }, | ||
|
|
@@ -75,7 +82,7 @@ const { | |
| }, | ||
| mutations: { | ||
| setWorkspaces(state, workspaces: string[]) { | ||
| state.workspaces = workspaces; | ||
| state.workspaces = workspaces.sort(); | ||
| }, | ||
|
|
||
| setCurrentWorkspace(state, workspace: WorkspaceState) { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.