Merged
Conversation
✅ Deploy Preview for multinet-client ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
JackWilb
changed the title
jjnesbitt
approved these changes
Sep 23, 2022
Member
jjnesbitt
left a comment
jjnesbitt
left a comment
There was a problem hiding this comment.
One comment but otherwise lgtm. I'd be okay merging this and fixing that as a follow up
| <v-spacer /> | ||
| <login-menu /> | ||
| <login-menu | ||
| :store="store" |
Member
There was a problem hiding this comment.
Passing the entire store seems excessive and is store implementation specific. IMO you should just pass what's needed here, the callbacks for logout and fetching user info.
Member
Author
There was a problem hiding this comment.
Yes, that's a better idea. It will take a refactor of the mutlinet-components, so let's defer it to an issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
No
Give a longer description of what this PR addresses and why it's needed
This is the first step on the path to using reusable components from a central
multinet-componentsrepo. I have preliminarily moved theLoginMenucomponent there, and I'm using that implementation here.To make this work, I had to change the implementation of the mdi-icons. We now use the same strategy as the other client apps, where we just get a css link in the index.html file.
Provide pictures/videos of the behavior before and after these changes (optional)
Before:
After:
Are there any additional TODOs before this PR is ready to go?
TODOs: