Skip to content
This repository was archived by the owner on Feb 23, 2022. It is now read-only.

Fix key specifier bug in csv uploader#356

Merged
jjnesbitt merged 4 commits intomasterfrom
fix_specify_csv
Mar 27, 2020
Merged

Fix key specifier bug in csv uploader#356
jjnesbitt merged 4 commits intomasterfrom
fix_specify_csv

Conversation

@jjnesbitt
Copy link
Copy Markdown
Member

I've left code comments in the affected areas, this is pretty much directly related to #352. Next steps after this is merged will be to address that issue.

JackWilb
JackWilb previously approved these changes Mar 26, 2020
Copy link
Copy Markdown
Member

@JackWilb JackWilb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

waxlamp
waxlamp previously approved these changes Mar 27, 2020
Comment thread multinet/uploaders/csv.py Outdated
@jjnesbitt jjnesbitt dismissed stale reviews from waxlamp and JackWilb via d629104 March 27, 2020 14:38
@jjnesbitt
Copy link
Copy Markdown
Member Author

@waxlamp or @JackWilb I need another review. I had modified something which I shouldn't have due to the complex logic in that code. It's a good thing we have tests for that though 👍 otherwise I wouldn't have caught it.

waxlamp
waxlamp previously approved these changes Mar 27, 2020
@jjnesbitt jjnesbitt merged commit 6658e79 into master Mar 27, 2020
@jjnesbitt jjnesbitt deleted the fix_specify_csv branch March 27, 2020 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants