This repository was archived by the owner on Feb 23, 2022. It is now read-only.
Conversation
jjnesbitt
force-pushed
the
splitup_validate_csv
branch
from
ea294f1 to
8ca7da4
Compare
JackWilb
reviewed
Apr 21, 2020
Member
JackWilb
left a comment
JackWilb
left a comment
There was a problem hiding this comment.
LGTM. Opened #360 with an edge case
waxlamp
suggested changes
Apr 22, 2020
Contributor
waxlamp
left a comment
waxlamp
left a comment
There was a problem hiding this comment.
Looks great overall. Had a few suggestions and questions.
Co-Authored-By: Jack Wilburn <jackwilburn@tutanota.com>
Co-Authored-By: Roni Choudhury <2903332+waxlamp@users.noreply.github.com>
…et-server into splitup_validate_csv
jjnesbitt
force-pushed
the
splitup_validate_csv
branch
from
8fea4cc to
bbb0411
Compare
waxlamp
approved these changes
Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #352.