This repository was archived by the owner on Feb 23, 2022. It is now read-only.
Conversation
waxlamp
suggested changes
Nov 6, 2020
Contributor
waxlamp
left a comment
waxlamp
left a comment
There was a problem hiding this comment.
This looks awesome. Thanks for being so fast. I have a few requested changes. If you'd prefer me to submit those changes for a counterreview by you (in the interest of time, mainly) please let me know.
JackWilb
suggested changes
Nov 6, 2020
Member
JackWilb
left a comment
JackWilb
left a comment
There was a problem hiding this comment.
Here are a couple of questions and a couple of copy-paste problems I found
2 tasks
This also updates the BadQueryArgument error, as it previously included an "allowed" field, which may not always apply.
waxlamp
approved these changes
Nov 9, 2020
JackWilb
approved these changes
Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #482
This is a basic first approach to table metadata. In this approach, table metadata is passed as a query string argument to the CSV upload endpoint. This is not ideal, and is only in place until this issue is addressed.
One of the side effects is that this PR slightly changes how tables are created. Now, the entire workspace instance is passed into the
Tableconstructor, which the constructor selects things from. This was mainly needed for referring to the workspace metadata collection. I actually think this approach is cleaner overall.