Skip to content

Use selector instead of bytes4(keccak256(method))#18

Open
k06a wants to merge 1 commit into
masterfrom
feature/selector
Open

Use selector instead of bytes4(keccak256(method))#18
k06a wants to merge 1 commit into
masterfrom
feature/selector

Conversation

@k06a
Copy link
Copy Markdown
Collaborator

@k06a k06a commented Sep 28, 2018

No description provided.

@k06a k06a requested a review from ZumZoom September 28, 2018 20:06
Copy link
Copy Markdown

@ZumZoom ZumZoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selectors feel like an unfinished feature for me. I think it'll be better to start using it in solidity 0.5.0 when they will finally implement unambiguous encoding like this or similar:

_token.transferFrom(address,address,uint256).selector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants