-
Notifications
You must be signed in to change notification settings - Fork 153
Update mxpy cookbook for v11 #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/sdk-and-tools/mxpy/mxpy-cli.md
Outdated
|
|
||
| #### Setting the explorer url | ||
|
|
||
| mxpy already knows the explorer urls for all three networks (Mainnet, Devnet, Testnet). This is particularly useful when running the CLI on custom networks where an explorer is also available. This key is not required to be present in the env config for the config to be valid. To set the explorer url use the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mxpy and env can be somehow emphasized (e.g. code / italic / bold).
docs/sdk-and-tools/mxpy/mxpy-cli.md
Outdated
| To delete an env config, we use the following command: | ||
|
|
||
| ```sh | ||
| mxpy env remove <config-name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, now I see that we have both "env delete" and "env remove" 🙈
Might be tricky for users...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say it's pretty well explained what they both do.
docs/sdk-and-tools/mxpy/mxpy-cli.md
Outdated
| mxpy address set kind pem | ||
| mxpy address set path absolute/path/to/pem/wallet.pem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I did not see this before - how does this work? Only for the default address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit tricky and ambiguous. Maybe we should let the users only adjust the properties while adding an alias, and not afterwards (that is, immutable entries).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for only mentioning this now 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed as discussed.
| As of October 2023, on Windows (or WSL), you might encounter some issues when trying to use Ledger in `mxpy`. | ||
| ::: | ||
|
|
||
| ## Interacting with the Multisig Smart Contract |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
| --proxy=https://devnet-gateway.multiversx.com | ||
| ``` | ||
|
|
||
| ## Interacting with the Governance Smart Contract |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
|
|
||
| ```sh | ||
| mxpy env set proxy_url https://devnet-api.multiversx.com | ||
| mxpy config-env set proxy_url https://devnet-api.multiversx.com --env devnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For readability, the parameter --env sould have been before ... oh, nevermind, the previous ones are positional parameters.
The base branch was changed.
Description of the pull request (what is new / what has changed)
Did you test the changes locally ?
Which category (categories) does this pull request belong to?