Map regions between AWS, Azure and GCP#384
Merged
Hidden character warning
The head ref may contain hidden characters: "\u0096map-regions"
Merged
Conversation
goncalo-rodrigues
requested changes
Jul 27, 2022
Member
goncalo-rodrigues
left a comment
goncalo-rodrigues
left a comment
There was a problem hiding this comment.
Thank you for working on this! I have added a few comments but looks good overall!
Member
|
Perfect, thanks for making the changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, does this seem like a good start to close #380?
Haven't updated
AMIMAPyet, because you have a link for ubuntu AMI's but i see Amazon linux AMI's are used.should i take it from here or the ubuntu link in the comments and change the others?