Skip to content

Hot fixes#22

Merged
GregJohnsonJr merged 10 commits intodevfrom
HotFixes
Aug 9, 2024
Merged

Hot fixes#22
GregJohnsonJr merged 10 commits intodevfrom
HotFixes

Conversation

@GregJohnsonJr
Copy link
Copy Markdown
Collaborator

No description provided.

GregJohnsonJr and others added 10 commits August 8, 2024 13:21
commit cb2fed7
Author: Allison R Mason <31289802+amason30@users.noreply.github.com>
Date:   Thu Aug 8 13:13:46 2024 -0400

    Release articles (#19)

    * Add functionality from PR 16 (#17)

    * Created RMD check full for our R package.

    * Create test-coverage.yml

    * Create lintr.yml

    * Release articles (#10)

    * set up filter article

    * add basic readme - consider adding background from original program manual

    * design logo?

    * switch article to quarto

    * add functionality for extracting a single filter summary

    * add check for technical replicates

    * add documentation for filter_summary

    * convert prints to cli and add checks for filter functions

    * add functionality to return a data.table of similar ions for mispicked workflow

    * add full draft filter article

    * update vignette builder

    * add usethis use_articles created .gitignore

    * initalize website with pkgdown

    * Relase bug fixes (#8) (#9)

    * Added functionality for multiple group filters.

    * Copy functionality added!

    * Custom print statement added!

    * RCMD check works!

    * Fixed incorrect summary after differnt filter runs

    Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>

    * fix typo to pass RCMD

    * fix partial group match warning in tests

    * remove non-exported function documentation

    * remove non-exported function documentation

    * add formatted website

    * demostrate copy and print functionality

    * add functionality to extract group averages table)

    * show step by step tree map

    * update text

    * return peak table, not a print of peak table

    * add accessor for cv values, error if cv filter has not been run failing

    * update accessor names

    * fix cv accessor test fail by changing name

    * fix typos

    * store raw peak table

    * remove man pages after changing names

    * set print inside class

    * Modified the constructor to allow for data.frames and data.tables to be passed through.

    * get_group_averages should return group averages of the filtered table at any stage

    * update variable names to be inclusive of data frame as input

    * add cv plot

    * show cv plot of cv filtered data only

    * format cv threshold plot for the article

    * add option for merging method, all tests pass

    * Add new method parameter to documentation

    * Require users to choose a cv_threshold

    * add new accessors to website

    * update roxygen version

    * create an example dataset that has both solvent and media blanks to show filtering both

    * Add in new example dataset, update filters, and show mutliple group filters

    * add downstream analysis article

    * add get_cv_data reference

    * add articles ignore

    * figure out how to order articles - does not work

    * update todo

    ---------

    Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
    Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

    * fix documentation errors in R CMD - check and all tests pass

    * ensure articles build

    * add vignette builder

    * Revert "fix documentation errors in R CMD - check and all tests pass"

    This reverts commit f40cd27.

    * changes to pass check

    * fix documentation warnings

    * no vignettes to build

    * add line ending to fix incomplete line warning

    * explain reference semantics sooner to introduce copy_object

    * run site through github actions

    * add in website formatting

    * see if quarto dependency fixes pkgdown namespace error

    * add quarto depends to website only

    * removing quarto from suggets cuases error in assigning vignetter builder

    * Update pkgdown.yaml

    add quarto to actions

    * add lines to solve endline error

    * Update DESCRIPTION

    * Update pkgdown.yaml, removed white spaces

    * load library, not load_all

    * Update _pkgdown.yml

    * article packages to website needs

    * Update pkgdown.yaml

    * dont use vignette builder - render as html

    * Create pkgdown_quarto.yml

    * run with default build_site

    * Update pkgdown_quarto.yml

    * Update pkgdown_quarto.yml

    * Update pkgdown_quarto.yml

    * Update pkgdown_quarto.yml

    * Update pkgdown_quarto.yml

    * go back to quarto vignette

    * Pkgdown Fixes (#12)

    * Created RMD check full for our R package.

    * Create test-coverage.yml

    * Create lintr.yml

    * explain reference semantics sooner to introduce copy_object

    * run site through github actions

    * add in website formatting

    * see if quarto dependency fixes pkgdown namespace error

    * add quarto depends to website only

    * removing quarto from suggets cuases error in assigning vignetter builder

    * Update pkgdown.yaml

    add quarto to actions

    * add lines to solve endline error

    * Update DESCRIPTION

    * Update pkgdown.yaml, removed white spaces

    * load library, not load_all

    * Update _pkgdown.yml

    * article packages to website needs

    * Update pkgdown.yaml

    * dont use vignette builder - render as html

    * Create pkgdown_quarto.yml

    * run with default build_site

    * Update pkgdown_quarto.yml

    * Update pkgdown_quarto.yml

    * Update pkgdown_quarto.yml

    * Update pkgdown_quarto.yml

    * Update pkgdown_quarto.yml

    * go back to quarto vignette

    ---------

    Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
    Co-authored-by: amason30 <masonar@umich.edu>

    * Prep for release (#14)

    * Created RMD check full for our R package.

    * Create test-coverage.yml

    * Create lintr.yml

    * explain reference semantics sooner to introduce copy_object

    * run site through github actions

    * add in website formatting

    * see if quarto dependency fixes pkgdown namespace error

    * add quarto depends to website only

    * removing quarto from suggets cuases error in assigning vignetter builder

    * Update pkgdown.yaml

    add quarto to actions

    * add lines to solve endline error

    * Update DESCRIPTION

    * Update pkgdown.yaml, removed white spaces

    * load library, not load_all

    * Update _pkgdown.yml

    * article packages to website needs

    * Update pkgdown.yaml

    * dont use vignette builder - render as html

    * Create pkgdown_quarto.yml

    * run with default build_site

    * Update pkgdown_quarto.yml

    * Update pkgdown_quarto.yml

    * Update pkgdown_quarto.yml

    * Update pkgdown_quarto.yml

    * Update pkgdown_quarto.yml

    * go back to quarto vignette

    * update todo

    * start formatter functions for mpactr class construction - tests pass, need to add to the import and constructor functions and test

    * Allow users to submit feature tables exported from different tools - need to fix global bindings warning for formatter script

    Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

    * update TODO

    * Fix for formatter issues!

    * Alpha numeric fix

    * add checks for expected meta_data columns

    Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

    * reorganize article to explain the example function sooner

    * remove notes

    * test coverage is 100 % for all main scripts

    * reduce size of example metabpscape df - no more CMD note

    * fix order of articles on website

    ---------

    Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
    Co-authored-by: amason30 <masonar@umich.edu>
    Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

    * Fix for Ubuntu failing test.

    * does adding project help?

    * Update pkgdown.yaml

    most recent example with quarto added

    * add project file

    * change qmd to rmd for pkgdown github actions website

    * Fix for r-cmd checks

    * Set mimimum R depend for base pipe

    * Update r.yml

    * Added a new lintr workflow

    * Update lintr.yml

    * Linted, styled the package!

    * Lintr (#16)

    * lint and style R dir - need to fix complexity error

    * lint and style raw data scripts - no errors

    * update name to snakecase

    * update manual pages after lint and styling

    * Fix small typos in filters documentation

    * Test have been linted!

    * Revert "Merge branch 'lintr' of https://github.com/SchlossLab/mpactR into lintr"

    This reverts commit 83e6f3e, reversing
    changes made to 318927f.

    * fix typos in articles an lint/style

    * add back typo fixes in filters documentation

    * fix character limit lintr issue

    * add an informative error message a filter has already been applied to input data object

    * add a designated reference semantics article

    * add copy_object explaination in filters details

    * fixed code to resolve knitting error

    * Fix for cyclomatic complexity.

    * Add in chemistry documentation suggestions

    * We don't recommend setting bounds to account for 0's in the table

    * add expanded section for R6 specifics

    * Link filter article on main page

    * be consistent with '.' in documentation

    * Fix typos and add in suggestions

    * allow https url for data input

    ---------

    Co-authored-by: YoungKrug <31873199+YoungKrug@users.noreply.github.com>

    ---------

    Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
    Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

    * remove quarto articles

    * add filter article with original mpact dataset

    * remove numeric name requirement and add informative message for group summary

    * check passed_ions as well, not failed_ions twice

    * use original mpact data for filter article

    * update readme with me article link

    ---------

    Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
    Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>
commit 61297f5c1ce7f5fca7a7386f38858daf469a891e
Author: YoungKrug <31873199+YoungKrug@users.noreply.github.com>
Date:   Fri Aug 9 11:24:21 2024 -0400

    Squashed commit of the following:

    commit c356c4c222378b1544b94714b8a7921a5f61e0af
    Author: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
    Date:   Thu Aug 8 17:16:42 2024 -0400

        Update test-coverage.yml

    commit 66b9cc0b29ca42d5bbef9930714cbd75bb886f16
    Author: YoungKrug <31873199+YoungKrug@users.noreply.github.com>
    Date:   Thu Aug 8 16:52:48 2024 -0400

        Fix for codecov

    commit cbb82daf1844fd5938fc98648f7cec125f3a3085
    Author: YoungKrug <31873199+YoungKrug@users.noreply.github.com>
    Date:   Thu Aug 8 16:43:34 2024 -0400

        Removal of Quarto release and updates to test_coverage.

    commit 428dc87a68615c8f3e4a53e49d2cf75e120bde52
    Author: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
    Date:   Thu Aug 8 15:57:37 2024 -0400

        Dev (#18)

        * set up filter article

        * add basic readme - consider adding background from original program manual

        * design logo?

        * switch article to quarto

        * add functionality for extracting a single filter summary

        * add check for technical replicates

        * add documentation for filter_summary

        * convert prints to cli and add checks for filter functions

        * add functionality to return a data.table of similar ions for mispicked workflow

        * add full draft filter article

        * update vignette builder

        * add usethis use_articles created .gitignore

        * initalize website with pkgdown

        * Relase bug fixes (#8) (#9)

        * Added functionality for multiple group filters.

        * Copy functionality added!

        * Custom print statement added!

        * RCMD check works!

        * Fixed incorrect summary after differnt filter runs

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>

        * fix typo to pass RCMD

        * fix partial group match warning in tests

        * remove non-exported function documentation

        * remove non-exported function documentation

        * add formatted website

        * demostrate copy and print functionality

        * add functionality to extract group averages table)

        * show step by step tree map

        * update text

        * return peak table, not a print of peak table

        * add accessor for cv values, error if cv filter has not been run failing

        * update accessor names

        * fix cv accessor test fail by changing name

        * fix typos

        * store raw peak table

        * remove man pages after changing names

        * set print inside class

        * Modified the constructor to allow for data.frames and data.tables to be passed through.

        * get_group_averages should return group averages of the filtered table at any stage

        * update variable names to be inclusive of data frame as input

        * add cv plot

        * show cv plot of cv filtered data only

        * format cv threshold plot for the article

        * add option for merging method, all tests pass

        * Add new method parameter to documentation

        * Require users to choose a cv_threshold

        * add new accessors to website

        * update roxygen version

        * create an example dataset that has both solvent and media blanks to show filtering both

        * Add in new example dataset, update filters, and show mutliple group filters

        * add downstream analysis article

        * add get_cv_data reference

        * add articles ignore

        * figure out how to order articles - does not work

        * update todo

        * Lintr (#16)

        * lint and style R dir - need to fix complexity error

        * lint and style raw data scripts - no errors

        * update name to snakecase

        * update manual pages after lint and styling

        * Fix small typos in filters documentation

        * Test have been linted!

        * Revert "Merge branch 'lintr' of https://github.com/SchlossLab/mpactR into lintr"

        This reverts commit 83e6f3e7c636c9e6254c396842d7e724958662a9, reversing
        changes made to 318927f66ed22048a57b3555c26b3a0a8a4073f5.

        * fix typos in articles an lint/style

        * add back typo fixes in filters documentation

        * fix character limit lintr issue

        * add an informative error message a filter has already been applied to input data object

        * add a designated reference semantics article

        * add copy_object explaination in filters details

        * fixed code to resolve knitting error

        * Fix for cyclomatic complexity.

        * Add in chemistry documentation suggestions

        * We don't recommend setting bounds to account for 0's in the table

        * add expanded section for R6 specifics

        * Link filter article on main page

        * be consistent with '.' in documentation

        * Fix typos and add in suggestions

        * allow https url for data input

        ---------

        Co-authored-by: YoungKrug <31873199+YoungKrug@users.noreply.github.com>

        * Release articles (#19)

        * Add functionality from PR 16 (#17)

        * Created RMD check full for our R package.

        * Create test-coverage.yml

        * Create lintr.yml

        * Release articles (#10)

        * set up filter article

        * add basic readme - consider adding background from original program manual

        * design logo?

        * switch article to quarto

        * add functionality for extracting a single filter summary

        * add check for technical replicates

        * add documentation for filter_summary

        * convert prints to cli and add checks for filter functions

        * add functionality to return a data.table of similar ions for mispicked workflow

        * add full draft filter article

        * update vignette builder

        * add usethis use_articles created .gitignore

        * initalize website with pkgdown

        * Relase bug fixes (#8) (#9)

        * Added functionality for multiple group filters.

        * Copy functionality added!

        * Custom print statement added!

        * RCMD check works!

        * Fixed incorrect summary after differnt filter runs

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>

        * fix typo to pass RCMD

        * fix partial group match warning in tests

        * remove non-exported function documentation

        * remove non-exported function documentation

        * add formatted website

        * demostrate copy and print functionality

        * add functionality to extract group averages table)

        * show step by step tree map

        * update text

        * return peak table, not a print of peak table

        * add accessor for cv values, error if cv filter has not been run failing

        * update accessor names

        * fix cv accessor test fail by changing name

        * fix typos

        * store raw peak table

        * remove man pages after changing names

        * set print inside class

        * Modified the constructor to allow for data.frames and data.tables to be passed through.

        * get_group_averages should return group averages of the filtered table at any stage

        * update variable names to be inclusive of data frame as input

        * add cv plot

        * show cv plot of cv filtered data only

        * format cv threshold plot for the article

        * add option for merging method, all tests pass

        * Add new method parameter to documentation

        * Require users to choose a cv_threshold

        * add new accessors to website

        * update roxygen version

        * create an example dataset that has both solvent and media blanks to show filtering both

        * Add in new example dataset, update filters, and show mutliple group filters

        * add downstream analysis article

        * add get_cv_data reference

        * add articles ignore

        * figure out how to order articles - does not work

        * update todo

        ---------

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * fix documentation errors in R CMD - check and all tests pass

        * ensure articles build

        * add vignette builder

        * Revert "fix documentation errors in R CMD - check and all tests pass"

        This reverts commit f40cd276f43874162d8cbad9d251ab7221afd422.

        * changes to pass check

        * fix documentation warnings

        * no vignettes to build

        * add line ending to fix incomplete line warning

        * explain reference semantics sooner to introduce copy_object

        * run site through github actions

        * add in website formatting

        * see if quarto dependency fixes pkgdown namespace error

        * add quarto depends to website only

        * removing quarto from suggets cuases error in assigning vignetter builder

        * Update pkgdown.yaml

        add quarto to actions

        * add lines to solve endline error

        * Update DESCRIPTION

        * Update pkgdown.yaml, removed white spaces

        * load library, not load_all

        * Update _pkgdown.yml

        * article packages to website needs

        * Update pkgdown.yaml

        * dont use vignette builder - render as html

        * Create pkgdown_quarto.yml

        * run with default build_site

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * go back to quarto vignette

        * Pkgdown Fixes (#12)

        * Created RMD check full for our R package.

        * Create test-coverage.yml

        * Create lintr.yml

        * explain reference semantics sooner to introduce copy_object

        * run site through github actions

        * add in website formatting

        * see if quarto dependency fixes pkgdown namespace error

        * add quarto depends to website only

        * removing quarto from suggets cuases error in assigning vignetter builder

        * Update pkgdown.yaml

        add quarto to actions

        * add lines to solve endline error

        * Update DESCRIPTION

        * Update pkgdown.yaml, removed white spaces

        * load library, not load_all

        * Update _pkgdown.yml

        * article packages to website needs

        * Update pkgdown.yaml

        * dont use vignette builder - render as html

        * Create pkgdown_quarto.yml

        * run with default build_site

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * go back to quarto vignette

        ---------

        Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
        Co-authored-by: amason30 <masonar@umich.edu>

        * Prep for release (#14)

        * Created RMD check full for our R package.

        * Create test-coverage.yml

        * Create lintr.yml

        * explain reference semantics sooner to introduce copy_object

        * run site through github actions

        * add in website formatting

        * see if quarto dependency fixes pkgdown namespace error

        * add quarto depends to website only

        * removing quarto from suggets cuases error in assigning vignetter builder

        * Update pkgdown.yaml

        add quarto to actions

        * add lines to solve endline error

        * Update DESCRIPTION

        * Update pkgdown.yaml, removed white spaces

        * load library, not load_all

        * Update _pkgdown.yml

        * article packages to website needs

        * Update pkgdown.yaml

        * dont use vignette builder - render as html

        * Create pkgdown_quarto.yml

        * run with default build_site

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * go back to quarto vignette

        * update todo

        * start formatter functions for mpactr class construction - tests pass, need to add to the import and constructor functions and test

        * Allow users to submit feature tables exported from different tools - need to fix global bindings warning for formatter script

        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * update TODO

        * Fix for formatter issues!

        * Alpha numeric fix

        * add checks for expected meta_data columns

        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * reorganize article to explain the example function sooner

        * remove notes

        * test coverage is 100 % for all main scripts

        * reduce size of example metabpscape df - no more CMD note

        * fix order of articles on website

        ---------

        Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
        Co-authored-by: amason30 <masonar@umich.edu>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * Fix for Ubuntu failing test.

        * does adding project help?

        * Update pkgdown.yaml

        most recent example with quarto added

        * add project file

        * change qmd to rmd for pkgdown github actions website

        * Fix for r-cmd checks

        * Set mimimum R depend for base pipe

        * Update r.yml

        * Added a new lintr workflow

        * Update lintr.yml

        * Linted, styled the package!

        * Lintr (#16)

        * lint and style R dir - need to fix complexity error

        * lint and style raw data scripts - no errors

        * update name to snakecase

        * update manual pages after lint and styling

        * Fix small typos in filters documentation

        * Test have been linted!

        * Revert "Merge branch 'lintr' of https://github.com/SchlossLab/mpactR into lintr"

        This reverts commit 83e6f3e7c636c9e6254c396842d7e724958662a9, reversing
        changes made to 318927f66ed22048a57b3555c26b3a0a8a4073f5.

        * fix typos in articles an lint/style

        * add back typo fixes in filters documentation

        * fix character limit lintr issue

        * add an informative error message a filter has already been applied to input data object

        * add a designated reference semantics article

        * add copy_object explaination in filters details

        * fixed code to resolve knitting error

        * Fix for cyclomatic complexity.

        * Add in chemistry documentation suggestions

        * We don't recommend setting bounds to account for 0's in the table

        * add expanded section for R6 specifics

        * Link filter article on main page

        * be consistent with '.' in documentation

        * Fix typos and add in suggestions

        * allow https url for data input

        ---------

        Co-authored-by: YoungKrug <31873199+YoungKrug@users.noreply.github.com>

        ---------

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * remove quarto articles

        * add filter article with original mpact dataset

        * remove numeric name requirement and add informative message for group summary

        * check passed_ions as well, not failed_ions twice

        * use original mpact data for filter article

        * update readme with me article link

        ---------

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * Hot fixes (#20)

        * Squashed commit of the following:

        commit cb2fed761b2b92336b585aec7a8a984249a9cbc9
        Author: Allison R Mason <31289802+amason30@users.noreply.github.com>
        Date:   Thu Aug 8 13:13:46 2024 -0400

            Release articles (#19)

            * Add functionality from PR 16 (#17)

            * Created RMD check full for our R package.

            * Create test-coverage.yml

            * Create lintr.yml

            * Release articles (#10)

            * set up filter article

            * add basic readme - consider adding background from original program manual

            * design logo?

            * switch article to quarto

            * add functionality for extracting a single filter summary

            * add check for technical replicates

            * add documentation for filter_summary

            * convert prints to cli and add checks for filter functions

            * add functionality to return a data.table of similar ions for mispicked workflow

            * add full draft filter article

            * update vignette builder

            * add usethis use_articles created .gitignore

            * initalize website with pkgdown

            * Relase bug fixes (#8) (#9)

            * Added functionality for multiple group filters.

            * Copy functionality added!

            * Custom print statement added!

            * RCMD check works!

            * Fixed incorrect summary after differnt filter runs

            Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>

            * fix typo to pass RCMD

            * fix partial group match warning in tests

            * remove non-exported function documentation

            * remove non-exported function documentation

            * add formatted website

            * demostrate copy and print functionality

            * add functionality to extract group averages table)

            * show step by step tree map

            * update text

            * return peak table, not a print of peak table

            * add accessor for cv values, error if cv filter has not been run failing

            * update accessor names

            * fix cv accessor test fail by changing name

            * fix typos

            * store raw peak table

            * remove man pages after changing names

            * set print inside class

            * Modified the constructor to allow for data.frames and data.tables to be passed through.

            * get_group_averages should return group averages of the filtered table at any stage

            * update variable names to be inclusive of data frame as input

            * add cv plot

            * show cv plot of cv filtered data only

            * format cv threshold plot for the article

            * add option for merging method, all tests pass

            * Add new method parameter to documentation

            * Require users to choose a cv_threshold

            * add new accessors to website

            * update roxygen version

            * create an example dataset that has both solvent and media blanks to show filtering both

            * Add in new example dataset, update filters, and show mutliple group filters

            * add downstream analysis article

            * add get_cv_data reference

            * add articles ignore

            * figure out how to order articles - does not work

            * update todo

            ---------

            Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
            Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

            * fix documentation errors in R CMD - check and all tests pass

            * ensure articles build

            * add vignette builder

            * Revert "fix documentation errors in R CMD - check and all tests pass"

            This reverts commit f40cd276f43874162d8cbad9d251ab7221afd422.

            * changes to pass check

            * fix documentation warnings

            * no vignettes to build

            * add line ending to fix incomplete line warning

            * explain reference semantics sooner to introduce copy_object

            * run site through github actions

            * add in website formatting

            * see if quarto dependency fixes pkgdown namespace error

            * add quarto depends to website only

            * removing quarto from suggets cuases error in assigning vignetter builder

            * Update pkgdown.yaml

            add quarto to actions

            * add lines to solve endline error

            * Update DESCRIPTION

            * Update pkgdown.yaml, removed white spaces

            * load library, not load_all

            * Update _pkgdown.yml

            * article packages to website needs

            * Update pkgdown.yaml

            * dont use vignette builder - render as html

            * Create pkgdown_quarto.yml

            * run with default build_site

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * go back to quarto vignette

            * Pkgdown Fixes (#12)

            * Created RMD check full for our R package.

            * Create test-coverage.yml

            * Create lintr.yml

            * explain reference semantics sooner to introduce copy_object

            * run site through github actions

            * add in website formatting

            * see if quarto dependency fixes pkgdown namespace error

            * add quarto depends to website only

            * removing quarto from suggets cuases error in assigning vignetter builder

            * Update pkgdown.yaml

            add quarto to actions

            * add lines to solve endline error

            * Update DESCRIPTION

            * Update pkgdown.yaml, removed white spaces

            * load library, not load_all

            * Update _pkgdown.yml

            * article packages to website needs

            * Update pkgdown.yaml

            * dont use vignette builder - render as html

            * Create pkgdown_quarto.yml

            * run with default build_site

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * go back to quarto vignette

            ---------

            Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
            Co-authored-by: amason30 <masonar@umich.edu>

            * Prep for release (#14)

            * Created RMD check full for our R package.

            * Create test-coverage.yml

            * Create lintr.yml

            * explain reference semantics sooner to introduce copy_object

            * run site through github actions

            * add in website formatting

            * see if quarto dependency fixes pkgdown namespace error

            * add quarto depends to website only

            * removing quarto from suggets cuases error in assigning vignetter builder

            * Update pkgdown.yaml

            add quarto to actions

            * add lines to solve endline error

            * Update DESCRIPTION

            * Update pkgdown.yaml, removed white spaces

            * load library, not load_all

            * Update _pkgdown.yml

            * article packages to website needs

            * Update pkgdown.yaml

            * dont use vignette builder - render as html

            * Create pkgdown_quarto.yml

            * run with default build_site

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * go back to quarto vignette

            * update todo

            * start formatter functions for mpactr class construction - tests pass, need to add to the import and constructor functions and test

            * Allow users to submit feature tables exported from different tools - need to fix global bindings warning for formatter script

            Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

            * update TODO

            * Fix for formatter issues!

            * Alpha numeric fix

            * add checks for expected meta_data columns

            Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

            * reorganize article to explain the example function sooner

            * remove notes

            * test coverage is 100 % for all main scripts

            * reduce size of example metabpscape df - no more CMD note

            * fix order of articles on website

            ---------

            Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
            Co-authored-by: amason30 <masonar@umich.edu>
            Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

            * Fix for Ubuntu failing test.

            * does adding project help?

            * Update pkgdown.yaml

            most recent example with quarto added

            * add project file

            * change qmd to rmd for pkgdown github actions website

            * Fix for r-cmd checks

            * Set mimimum R depend for base pipe

            * Update r.yml

            * Added a new lintr workflow

            * Update lintr.yml

            * Linted, styled the package!

            * Lintr (#16)

            * lint and style R dir - need to fix complexity error

            * lint and style raw data scripts - no errors

            * update name to snakecase

            * update manual pages after lint and styling

            * Fix small typos in filters documentation

            * Test have been linted!

            * Revert "Merge branch 'lintr' of https://github.com/SchlossLab/mpactR into lintr"

            This reverts commit 83e6f3e7c636c9e6254c396842d7e724958662a9, reversing
            changes made to 318927f66ed22048a57b3555c26b3a0a8a4073f5.

            * fix typos in articles an lint/style

            * add back typo fixes in filters documentation

            * fix character limit lintr issue

            * add an informative error message a filter has already been applied to input data object

            * add a designated reference semantics article

            * add copy_object explaination in filters details

            * fixed code to resolve knitting error

            * Fix for cyclomatic complexity.

            * Add in chemistry documentation suggestions

            * We don't recommend setting bounds to account for 0's in the table

            * add expanded section for R6 specifics

            * Link filter article on main page

            * be consistent with '.' in documentation

            * Fix typos and add in suggestions

            * allow https url for data input

            ---------

            Co-authored-by: YoungKrug <31873199+YoungKrug@users.noreply.github.com>

            ---------

            Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
            Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

            * remove quarto articles

            * add filter article with original mpact dataset

            * remove numeric name requirement and add informative message for group summary

            * check passed_ions as well, not failed_ions twice

            * use original mpact data for filter article

            * update readme with me article link

            ---------

            Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
            Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * Fix for examples, and fixing lintr issues.

        * Fixed failed test issues.

        * Fixes to cli issue and lintr problems

        ---------

        Co-authored-by: YoungKrug <31873199+YoungKrug@users.noreply.github.com>

        * Hot fixes (#21)

        * Squashed commit of the following:

        commit cb2fed761b2b92336b585aec7a8a984249a9cbc9
        Author: Allison R Mason <31289802+amason30@users.noreply.github.com>
        Date:   Thu Aug 8 13:13:46 2024 -0400

            Release articles (#19)

            * Add functionality from PR 16 (#17)

            * Created RMD check full for our R package.

            * Create test-coverage.yml

            * Create lintr.yml

            * Release articles (#10)

            * set up filter article

            * add basic readme - consider adding background from original program manual

            * design logo?

            * switch article to quarto

            * add functionality for extracting a single filter summary

            * add check for technical replicates

            * add documentation for filter_summary

            * convert prints to cli and add checks for filter functions

            * add functionality to return a data.table of similar ions for mispicked workflow

            * add full draft filter article

            * update vignette builder

            * add usethis use_articles created .gitignore

            * initalize website with pkgdown

            * Relase bug fixes (#8) (#9)

            * Added functionality for multiple group filters.

            * Copy functionality added!

            * Custom print statement added!

            * RCMD check works!

            * Fixed incorrect summary after differnt filter runs

            Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>

            * fix typo to pass RCMD

            * fix partial group match warning in tests

            * remove non-exported function documentation

            * remove non-exported function documentation

            * add formatted website

            * demostrate copy and print functionality

            * add functionality to extract group averages table)

            * show step by step tree map

            * update text

            * return peak table, not a print of peak table

            * add accessor for cv values, error if cv filter has not been run failing

            * update accessor names

            * fix cv accessor test fail by changing name

            * fix typos

            * store raw peak table

            * remove man pages after changing names

            * set print inside class

            * Modified the constructor to allow for data.frames and data.tables to be passed through.

            * get_group_averages should return group averages of the filtered table at any stage

            * update variable names to be inclusive of data frame as input

            * add cv plot

            * show cv plot of cv filtered data only

            * format cv threshold plot for the article

            * add option for merging method, all tests pass

            * Add new method parameter to documentation

            * Require users to choose a cv_threshold

            * add new accessors to website

            * update roxygen version

            * create an example dataset that has both solvent and media blanks to show filtering both

            * Add in new example dataset, update filters, and show mutliple group filters

            * add downstream analysis article

            * add get_cv_data reference

            * add articles ignore

            * figure out how to order articles - does not work

            * update todo

            ---------

            Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
            Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

            * fix documentation errors in R CMD - check and all tests pass

            * ensure articles build

            * add vignette builder

            * Revert "fix documentation errors in R CMD - check and all tests pass"

            This reverts commit f40cd276f43874162d8cbad9d251ab7221afd422.

            * changes to pass check

            * fix documentation warnings

            * no vignettes to build

            * add line ending to fix incomplete line warning

            * explain reference semantics sooner to introduce copy_object

            * run site through github actions

            * add in website formatting

            * see if quarto dependency fixes pkgdown namespace error

            * add quarto depends to website only

            * removing quarto from suggets cuases error in assigning vignetter builder

            * Update pkgdown.yaml

            add quarto to actions

            * add lines to solve endline error

            * Update DESCRIPTION

            * Update pkgdown.yaml, removed white spaces

            * load library, not load_all

            * Update _pkgdown.yml

            * article packages to website needs

            * Update pkgdown.yaml

            * dont use vignette builder - render as html

            * Create pkgdown_quarto.yml

            * run with default build_site

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * go back to quarto vignette

            * Pkgdown Fixes (#12)

            * Created RMD check full for our R package.

            * Create test-coverage.yml

            * Create lintr.yml

            * explain reference semantics sooner to introduce copy_object

            * run site through github actions

            * add in website formatting

            * see if quarto dependency fixes pkgdown namespace error

            * add quarto depends to website only

            * removing quarto from suggets cuases error in assigning vignetter builder

            * Update pkgdown.yaml

            add quarto to actions

            * add lines to solve endline error

            * Update DESCRIPTION

            * Update pkgdown.yaml, removed white spaces

            * load library, not load_all

            * Update _pkgdown.yml

            * article packages to website needs

            * Update pkgdown.yaml

            * dont use vignette builder - render as html

            * Create pkgdown_quarto.yml

            * run with default build_site

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * go back to quarto vignette

            ---------

            Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
            Co-authored-by: amason30 <masonar@umich.edu>

            * Prep for release (#14)

            * Created RMD check full for our R package.

            * Create test-coverage.yml

            * Create lintr.yml

            * explain reference semantics sooner to introduce copy_object

            * run site through github actions

            * add in website formatting

            * see if quarto dependency fixes pkgdown namespace error

            * add quarto depends to website only

            * removing quarto from suggets cuases error in assigning vignetter builder

            * Update pkgdown.yaml

            add quarto to actions

            * add lines to solve endline error

            * Update DESCRIPTION

            * Update pkgdown.yaml, removed white spaces

            * load library, not load_all

            * Update _pkgdown.yml

            * article packages to website needs

            * Update pkgdown.yaml

            * dont use vignette builder - render as html

            * Create pkgdown_quarto.yml

            * run with default build_site

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * Update pkgdown_quarto.yml

            * go back to quarto vignette

            * update todo

            * start formatter functions for mpactr class construction - tests pass, need to add to the import and constructor functions and test

            * Allow users to submit feature tables exported from different tools - need to fix global bindings warning for formatter script

            Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

            * update TODO

            * Fix for formatter issues!

            * Alpha numeric fix

            * add checks for expected meta_data columns

            Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

            * reorganize article to explain the example function sooner

            * remove notes

            * test coverage is 100 % for all main scripts

            * reduce size of example metabpscape df - no more CMD note

            * fix order of articles on website

            ---------

            Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
            Co-authored-by: amason30 <masonar@umich.edu>
            Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

            * Fix for Ubuntu failing test.

            * does adding project help?

            * Update pkgdown.yaml

            most recent example with quarto added

            * add project file

            * change qmd to rmd for pkgdown github actions website

            * Fix for r-cmd checks

            * Set mimimum R depend for base pipe

            * Update r.yml

            * Added a new lintr workflow

            * Update lintr.yml

            * Linted, styled the package!

            * Lintr (#16)

            * lint and style R dir - need to fix complexity error

            * lint and style raw data scripts - no errors

            * update name to snakecase

            * update manual pages after lint and styling

            * Fix small typos in filters documentation

            * Test have been linted!

            * Revert "Merge branch 'lintr' of https://github.com/SchlossLab/mpactR into lintr"

            This reverts commit 83e6f3e7c636c9e6254c396842d7e724958662a9, reversing
            changes made to 318927f66ed22048a57b3555c26b3a0a8a4073f5.

            * fix typos in articles an lint/style

            * add back typo fixes in filters documentation

            * fix character limit lintr issue

            * add an informative error message a filter has already been applied to input data object

            * add a designated reference semantics article

            * add copy_object explaination in filters details

            * fixed code to resolve knitting error

            * Fix for cyclomatic complexity.

            * Add in chemistry documentation suggestions

            * We don't recommend setting bounds to account for 0's in the table

            * add expanded section for R6 specifics

            * Link filter article on main page

            * be consistent with '.' in documentation

            * Fix typos and add in suggestions

            * allow https url for data input

            ---------

            Co-authored-by: YoungKrug <31873199+YoungKrug@users.noreply.github.com>

            ---------

            Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
            Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

            * remove quarto articles

            * add filter article with original mpact dataset

            * remove numeric name requirement and add informative message for group summary

            * check passed_ions as well, not failed_ions twice

            * use original mpact data for filter article

            * update readme with me article link

            ---------

            Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
            Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * Fix for examples, and fixing lintr issues.

        * Fixed failed test issues.

        * Fixes to cli issue and lintr problems

        * lintr and pkgdown errors fixed

        ---------

        Co-authored-by: amason30 <masonar@umich.edu>
        Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>

        * fix pkgdown error for library call

        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * fix pkgdown error to library call

        * fix pkgdown error for library call

        ---------

        Co-authored-by: amason30 <masonar@umich.edu>
        Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

commit 8c13f5a990d0744dce0b7f69555046cac6fa3438
Author: amason30 <masonar@umich.edu>
Date:   Thu Aug 8 15:40:24 2024 -0400

    fix pkgdown error for library call

commit 54588ab4b5add79a191ace6cc4ef24b81440b99b
Author: amason30 <masonar@umich.edu>
Date:   Thu Aug 8 15:39:46 2024 -0400

    fix pkgdown error to library call

commit 6f5663be6d8e773c12e4939c3edd54053350bd8e
Author: amason30 <masonar@umich.edu>
Date:   Thu Aug 8 15:38:43 2024 -0400

    fix pkgdown error for library call

    Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

commit 69bc8fb4c896eba8aec693bf8d6142084e44844e
Author: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
Date:   Thu Aug 8 15:33:15 2024 -0400

    Hot fixes (#21)

    * Squashed commit of the following:

    commit cb2fed761b2b92336b585aec7a8a984249a9cbc9
    Author: Allison R Mason <31289802+amason30@users.noreply.github.com>
    Date:   Thu Aug 8 13:13:46 2024 -0400

        Release articles (#19)

        * Add functionality from PR 16 (#17)

        * Created RMD check full for our R package.

        * Create test-coverage.yml

        * Create lintr.yml

        * Release articles (#10)

        * set up filter article

        * add basic readme - consider adding background from original program manual

        * design logo?

        * switch article to quarto

        * add functionality for extracting a single filter summary

        * add check for technical replicates

        * add documentation for filter_summary

        * convert prints to cli and add checks for filter functions

        * add functionality to return a data.table of similar ions for mispicked workflow

        * add full draft filter article

        * update vignette builder

        * add usethis use_articles created .gitignore

        * initalize website with pkgdown

        * Relase bug fixes (#8) (#9)

        * Added functionality for multiple group filters.

        * Copy functionality added!

        * Custom print statement added!

        * RCMD check works!

        * Fixed incorrect summary after differnt filter runs

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>

        * fix typo to pass RCMD

        * fix partial group match warning in tests

        * remove non-exported function documentation

        * remove non-exported function documentation

        * add formatted website

        * demostrate copy and print functionality

        * add functionality to extract group averages table)

        * show step by step tree map

        * update text

        * return peak table, not a print of peak table

        * add accessor for cv values, error if cv filter has not been run failing

        * update accessor names

        * fix cv accessor test fail by changing name

        * fix typos

        * store raw peak table

        * remove man pages after changing names

        * set print inside class

        * Modified the constructor to allow for data.frames and data.tables to be passed through.

        * get_group_averages should return group averages of the filtered table at any stage

        * update variable names to be inclusive of data frame as input

        * add cv plot

        * show cv plot of cv filtered data only

        * format cv threshold plot for the article

        * add option for merging method, all tests pass

        * Add new method parameter to documentation

        * Require users to choose a cv_threshold

        * add new accessors to website

        * update roxygen version

        * create an example dataset that has both solvent and media blanks to show filtering both

        * Add in new example dataset, update filters, and show mutliple group filters

        * add downstream analysis article

        * add get_cv_data reference

        * add articles ignore

        * figure out how to order articles - does not work

        * update todo

        ---------

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * fix documentation errors in R CMD - check and all tests pass

        * ensure articles build

        * add vignette builder

        * Revert "fix documentation errors in R CMD - check and all tests pass"

        This reverts commit f40cd276f43874162d8cbad9d251ab7221afd422.

        * changes to pass check

        * fix documentation warnings

        * no vignettes to build

        * add line ending to fix incomplete line warning

        * explain reference semantics sooner to introduce copy_object

        * run site through github actions

        * add in website formatting

        * see if quarto dependency fixes pkgdown namespace error

        * add quarto depends to website only

        * removing quarto from suggets cuases error in assigning vignetter builder

        * Update pkgdown.yaml

        add quarto to actions

        * add lines to solve endline error

        * Update DESCRIPTION

        * Update pkgdown.yaml, removed white spaces

        * load library, not load_all

        * Update _pkgdown.yml

        * article packages to website needs

        * Update pkgdown.yaml

        * dont use vignette builder - render as html

        * Create pkgdown_quarto.yml

        * run with default build_site

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * go back to quarto vignette

        * Pkgdown Fixes (#12)

        * Created RMD check full for our R package.

        * Create test-coverage.yml

        * Create lintr.yml

        * explain reference semantics sooner to introduce copy_object

        * run site through github actions

        * add in website formatting

        * see if quarto dependency fixes pkgdown namespace error

        * add quarto depends to website only

        * removing quarto from suggets cuases error in assigning vignetter builder

        * Update pkgdown.yaml

        add quarto to actions

        * add lines to solve endline error

        * Update DESCRIPTION

        * Update pkgdown.yaml, removed white spaces

        * load library, not load_all

        * Update _pkgdown.yml

        * article packages to website needs

        * Update pkgdown.yaml

        * dont use vignette builder - render as html

        * Create pkgdown_quarto.yml

        * run with default build_site

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * go back to quarto vignette

        ---------

        Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
        Co-authored-by: amason30 <masonar@umich.edu>

        * Prep for release (#14)

        * Created RMD check full for our R package.

        * Create test-coverage.yml

        * Create lintr.yml

        * explain reference semantics sooner to introduce copy_object

        * run site through github actions

        * add in website formatting

        * see if quarto dependency fixes pkgdown namespace error

        * add quarto depends to website only

        * removing quarto from suggets cuases error in assigning vignetter builder

        * Update pkgdown.yaml

        add quarto to actions

        * add lines to solve endline error

        * Update DESCRIPTION

        * Update pkgdown.yaml, removed white spaces

        * load library, not load_all

        * Update _pkgdown.yml

        * article packages to website needs

        * Update pkgdown.yaml

        * dont use vignette builder - render as html

        * Create pkgdown_quarto.yml

        * run with default build_site

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * go back to quarto vignette

        * update todo

        * start formatter functions for mpactr class construction - tests pass, need to add to the import and constructor functions and test

        * Allow users to submit feature tables exported from different tools - need to fix global bindings warning for formatter script

        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * update TODO

        * Fix for formatter issues!

        * Alpha numeric fix

        * add checks for expected meta_data columns

        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * reorganize article to explain the example function sooner

        * remove notes

        * test coverage is 100 % for all main scripts

        * reduce size of example metabpscape df - no more CMD note

        * fix order of articles on website

        ---------

        Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
        Co-authored-by: amason30 <masonar@umich.edu>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * Fix for Ubuntu failing test.

        * does adding project help?

        * Update pkgdown.yaml

        most recent example with quarto added

        * add project file

        * change qmd to rmd for pkgdown github actions website

        * Fix for r-cmd checks

        * Set mimimum R depend for base pipe

        * Update r.yml

        * Added a new lintr workflow

        * Update lintr.yml

        * Linted, styled the package!

        * Lintr (#16)

        * lint and style R dir - need to fix complexity error

        * lint and style raw data scripts - no errors

        * update name to snakecase

        * update manual pages after lint and styling

        * Fix small typos in filters documentation

        * Test have been linted!

        * Revert "Merge branch 'lintr' of https://github.com/SchlossLab/mpactR into lintr"

        This reverts commit 83e6f3e7c636c9e6254c396842d7e724958662a9, reversing
        changes made to 318927f66ed22048a57b3555c26b3a0a8a4073f5.

        * fix typos in articles an lint/style

        * add back typo fixes in filters documentation

        * fix character limit lintr issue

        * add an informative error message a filter has already been applied to input data object

        * add a designated reference semantics article

        * add copy_object explaination in filters details

        * fixed code to resolve knitting error

        * Fix for cyclomatic complexity.

        * Add in chemistry documentation suggestions

        * We don't recommend setting bounds to account for 0's in the table

        * add expanded section for R6 specifics

        * Link filter article on main page

        * be consistent with '.' in documentation

        * Fix typos and add in suggestions

        * allow https url for data input

        ---------

        Co-authored-by: YoungKrug <31873199+YoungKrug@users.noreply.github.com>

        ---------

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * remove quarto articles

        * add filter article with original mpact dataset

        * remove numeric name requirement and add informative message for group summary

        * check passed_ions as well, not failed_ions twice

        * use original mpact data for filter article

        * update readme with me article link

        ---------

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

    * Fix for examples, and fixing lintr issues.

    * Fixed failed test issues.

    * Fixes to cli issue and lintr problems

    * lintr and pkgdown errors fixed

    ---------

    Co-authored-by: amason30 <masonar@umich.edu>
    Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>

commit 6fde45e043ff78e096abcbc040641681d314ba22
Author: Allison R Mason <31289802+amason30@users.noreply.github.com>
Date:   Thu Aug 8 15:08:50 2024 -0400

    Hot fixes (#20)

    * Squashed commit of the following:

    commit cb2fed761b2b92336b585aec7a8a984249a9cbc9
    Author: Allison R Mason <31289802+amason30@users.noreply.github.com>
    Date:   Thu Aug 8 13:13:46 2024 -0400

        Release articles (#19)

        * Add functionality from PR 16 (#17)

        * Created RMD check full for our R package.

        * Create test-coverage.yml

        * Create lintr.yml

        * Release articles (#10)

        * set up filter article

        * add basic readme - consider adding background from original program manual

        * design logo?

        * switch article to quarto

        * add functionality for extracting a single filter summary

        * add check for technical replicates

        * add documentation for filter_summary

        * convert prints to cli and add checks for filter functions

        * add functionality to return a data.table of similar ions for mispicked workflow

        * add full draft filter article

        * update vignette builder

        * add usethis use_articles created .gitignore

        * initalize website with pkgdown

        * Relase bug fixes (#8) (#9)

        * Added functionality for multiple group filters.

        * Copy functionality added!

        * Custom print statement added!

        * RCMD check works!

        * Fixed incorrect summary after differnt filter runs

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>

        * fix typo to pass RCMD

        * fix partial group match warning in tests

        * remove non-exported function documentation

        * remove non-exported function documentation

        * add formatted website

        * demostrate copy and print functionality

        * add functionality to extract group averages table)

        * show step by step tree map

        * update text

        * return peak table, not a print of peak table

        * add accessor for cv values, error if cv filter has not been run failing

        * update accessor names

        * fix cv accessor test fail by changing name

        * fix typos

        * store raw peak table

        * remove man pages after changing names

        * set print inside class

        * Modified the constructor to allow for data.frames and data.tables to be passed through.

        * get_group_averages should return group averages of the filtered table at any stage

        * update variable names to be inclusive of data frame as input

        * add cv plot

        * show cv plot of cv filtered data only

        * format cv threshold plot for the article

        * add option for merging method, all tests pass

        * Add new method parameter to documentation

        * Require users to choose a cv_threshold

        * add new accessors to website

        * update roxygen version

        * create an example dataset that has both solvent and media blanks to show filtering both

        * Add in new example dataset, update filters, and show mutliple group filters

        * add downstream analysis article

        * add get_cv_data reference

        * add articles ignore

        * figure out how to order articles - does not work

        * update todo

        ---------

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * fix documentation errors in R CMD - check and all tests pass

        * ensure articles build

        * add vignette builder

        * Revert "fix documentation errors in R CMD - check and all tests pass"

        This reverts commit f40cd276f43874162d8cbad9d251ab7221afd422.

        * changes to pass check

        * fix documentation warnings

        * no vignettes to build

        * add line ending to fix incomplete line warning

        * explain reference semantics sooner to introduce copy_object

        * run site through github actions

        * add in website formatting

        * see if quarto dependency fixes pkgdown namespace error

        * add quarto depends to website only

        * removing quarto from suggets cuases error in assigning vignetter builder

        * Update pkgdown.yaml

        add quarto to actions

        * add lines to solve endline error

        * Update DESCRIPTION

        * Update pkgdown.yaml, removed white spaces

        * load library, not load_all

        * Update _pkgdown.yml

        * article packages to website needs

        * Update pkgdown.yaml

        * dont use vignette builder - render as html

        * Create pkgdown_quarto.yml

        * run with default build_site

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * go back to quarto vignette

        * Pkgdown Fixes (#12)

        * Created RMD check full for our R package.

        * Create test-coverage.yml

        * Create lintr.yml

        * explain reference semantics sooner to introduce copy_object

        * run site through github actions

        * add in website formatting

        * see if quarto dependency fixes pkgdown namespace error

        * add quarto depends to website only

        * removing quarto from suggets cuases error in assigning vignetter builder

        * Update pkgdown.yaml

        add quarto to actions

        * add lines to solve endline error

        * Update DESCRIPTION

        * Update pkgdown.yaml, removed white spaces

        * load library, not load_all

        * Update _pkgdown.yml

        * article packages to website needs

        * Update pkgdown.yaml

        * dont use vignette builder - render as html

        * Create pkgdown_quarto.yml

        * run with default build_site

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * go back to quarto vignette

        ---------

        Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
        Co-authored-by: amason30 <masonar@umich.edu>

        * Prep for release (#14)

        * Created RMD check full for our R package.

        * Create test-coverage.yml

        * Create lintr.yml

        * explain reference semantics sooner to introduce copy_object

        * run site through github actions

        * add in website formatting

        * see if quarto dependency fixes pkgdown namespace error

        * add quarto depends to website only

        * removing quarto from suggets cuases error in assigning vignetter builder

        * Update pkgdown.yaml

        add quarto to actions

        * add lines to solve endline error

        * Update DESCRIPTION

        * Update pkgdown.yaml, removed white spaces

        * load library, not load_all

        * Update _pkgdown.yml

        * article packages to website needs

        * Update pkgdown.yaml

        * dont use vignette builder - render as html

        * Create pkgdown_quarto.yml

        * run with default build_site

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * Update pkgdown_quarto.yml

        * go back to quarto vignette

        * update todo

        * start formatter functions for mpactr class construction - tests pass, need to add to the import and constructor functions and test

        * Allow users to submit feature tables exported from different tools - need to fix global bindings warning for formatter script

        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * update TODO

        * Fix for formatter issues!

        * Alpha numeric fix

        * add checks for expected meta_data columns

        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * reorganize article to explain the example function sooner

        * remove notes

        * test coverage is 100 % for all main scripts

        * reduce size of example metabpscape df - no more CMD note

        * fix order of articles on website

        ---------

        Co-authored-by: Allison R Mason <31289802+amason30@users.noreply.github.com>
        Co-authored-by: amason30 <masonar@umich.edu>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * Fix for Ubuntu failing test.

        * does adding project help?

        * Update pkgdown.yaml

        most recent example with quarto added

        * add project file

        * change qmd to rmd for pkgdown github actions website

        * Fix for r-cmd checks

        * Set mimimum R depend for base pipe

        * Update r.yml

        * Added a new lintr workflow

        * Update lintr.yml

        * Linted, styled the package!

        * Lintr (#16)

        * lint and style R dir - need to fix complexity error

        * lint and style raw data scripts - no errors

        * update name to snakecase

        * update manual pages after lint and styling

        * Fix small typos in filters documentation

        * Test have been linted!

        * Revert "Merge branch 'lintr' of https://github.com/SchlossLab/mpactR into lintr"

        This reverts commit 83e6f3e7c636c9e6254c396842d7e724958662a9, reversing
        changes made to 318927f66ed22048a57b3555c26b3a0a8a4073f5.

        * fix typos in articles an lint/style

        * add back typo fixes in filters documentation

        * fix character limit lintr issue

        * add an informative error message a filter has already been applied to input data object

        * add a designated reference semantics article

        * add copy_object explaination in filters details

        * fixed code to resolve knitting error

        * Fix for cyclomatic complexity.

        * Add in chemistry documentation suggestions

        * We don't recommend setting bounds to account for 0's in the table

        * add expanded section for R6 specifics

        * Link filter article on main page

        * be consistent with '.' in documentation

        * Fix typos and add in suggestions

        * allow https url for data input

        ---------

        Co-authored-by: YoungKrug <31873199+YoungKrug@users.noreply.github.com>

        ---------

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

        * remove quarto articles

        * add filter article with original mpact dataset

        * remove numeric name requirement and add informative message for group summary

        * check passed_ions as well, not failed_ions twice

        * use original mpact data for filter article

        * update readme with me article link

        ---------

        Co-authored-by: GregJohnson <31873199+YoungKrug@users.noreply.github.com>
        Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>

    * Fix for examples, and fixing lintr issues.

    * Fixed failed test issues.

    * Fixes to cli issue and lintr problems

    ---------

    Co-authored-by: YoungKrug <31873199+YoungKrug@users.noreply.github.com>
@GregJohnsonJr GregJohnsonJr self-assigned this Aug 9, 2024
@GregJohnsonJr GregJohnsonJr merged commit 004972b into dev Aug 9, 2024
@GregJohnsonJr GregJohnsonJr deleted the HotFixes branch August 9, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants