Skip to content

Fix compound duplication#36

Merged
GregJohnsonJr merged 2 commits intodevfrom
FixCompoundDuplication
Mar 10, 2025
Merged

Fix compound duplication#36
GregJohnsonJr merged 2 commits intodevfrom
FixCompoundDuplication

Conversation

@GregJohnsonJr
Copy link
Copy Markdown
Collaborator

Fixing #33 and related to #34 .

Essentially fixing the duplication error that was never found. When data tables have duplicate names in different rows, it causes the melt function to default all values to 1. This should be fixed now.

@GregJohnsonJr GregJohnsonJr added the bug Something isn't working label Mar 10, 2025
@GregJohnsonJr GregJohnsonJr self-assigned this Mar 10, 2025
@GregJohnsonJr
Copy link
Copy Markdown
Collaborator Author

Have confirmed that this indeed fixes #35

@GregJohnsonJr GregJohnsonJr merged commit 95d1894 into dev Mar 10, 2025
@GregJohnsonJr GregJohnsonJr linked an issue Mar 10, 2025 that may be closed by this pull request
@GregJohnsonJr GregJohnsonJr deleted the FixCompoundDuplication branch March 10, 2025 19:47
@GregJohnsonJr GregJohnsonJr restored the FixCompoundDuplication branch March 11, 2025 14:21
GregJohnsonJr added a commit that referenced this pull request Mar 11, 2025
commit 95d1894
Author: Gregory Johnson <31873199+GregJohnsonJr@users.noreply.github.com>
Date:   Mon Mar 10 15:42:40 2025 -0400

    Fix compound duplication (#36)

    * Fix for #35

    * Added Test data, and new test for the new unique_compounds function.
Merge branch 'dev' into FixCompoundDuplication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix case sensitive bug

1 participant