Skip to content

Peak table formatter bug#44

Merged
GregJohnsonJr merged 4 commits intodevfrom
PeakTableFormatterBug
Mar 28, 2025
Merged

Peak table formatter bug#44
GregJohnsonJr merged 4 commits intodevfrom
PeakTableFormatterBug

Conversation

@GregJohnsonJr
Copy link
Copy Markdown
Collaborator

This should be the fix for #43 . It appears when data.table was joining the data together, it was creating NA rows. This in combination with unique duplicates caused an infinite loop (since we cannot add characters to a NA type).

@GregJohnsonJr GregJohnsonJr added the bug Something isn't working label Mar 28, 2025
@GregJohnsonJr GregJohnsonJr self-assigned this Mar 28, 2025
@GregJohnsonJr GregJohnsonJr linked an issue Mar 28, 2025 that may be closed by this pull request
@GregJohnsonJr GregJohnsonJr removed a link to an issue Mar 28, 2025
@GregJohnsonJr GregJohnsonJr merged commit 1301b22 into dev Mar 28, 2025
@GregJohnsonJr GregJohnsonJr deleted the PeakTableFormatterBug branch March 28, 2025 18:23
@GregJohnsonJr GregJohnsonJr linked an issue Apr 1, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mpactr 0.2.1

1 participant