Merged
Conversation
Co-authored-by: GregJohnson <YoungKrug@users.noreply.github.com>
* Testing a solution by taking the percentage of features that passed the CV filter. Checking to see if this removes noise without remain high quality features. * Small fix for new cv filter method * Adding a new method for the cv filter * Cleaning up test and code for new cv filter * Fixing lintr * Optimizing the new cv filter function. Everything is linted and test return the proper results. * Fixed test, vignette and functions to reflect the cv filter changes!
… `import_data()` function. Also modified test.
* Fixing typos and starting to implement a new recursive method for mpactr * Added a function for permutations and started creating a function that recursively goes back to to other features to check if they pass a secondary check. * Can create a CV table, but the table is required to be sorted, need to find a better solution * recursive method for peaking peaks work properly and speed up the traditional version using c++. * New peak filter method for cv filter. Will now check if other permutations of failed peaks pass the cv filter. * Removing browser statements and renaming PeakTable.cpp to CvFilter.cpp * Fixing typos * Removing the fix peak method from mpactr. * Fixed a group and sample code mismatch error in mpactr! * Changed "CV" to "cv" in the GetCvTable() function. * Fixing lintr * Modifying the news.md to reflect changes and fixing the ggplot2 plot issue via #50 * Increment version number to 0.3.0 * Adding docs to build ignore and fixing line endings in makevars (make file)
…e not previously implemented.
…incrementing the package version.
…ng it to every test and example so we can pass cran checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing CRAN check issue:
"Running R code in ‘testthat.R’ had CPU time 7.7 times elapsed time."
Had to create a
limit_cores()function, which limits the amount of core/threads used by openmp. It is believed that data.table is using more cores than needed and this should fix it.Also fixed more typos in test.