Open
Conversation
Author
|
@munkm tagging you in this comment since I can't figure out how to request your review for some reason |
munkm
reviewed
Apr 30, 2024
source/cep/cep3.rst
Outdated
Comment on lines
342
to
344
| **Update GTest:** We fetch the GTest source code during our CMake build. To keep up with | ||
| GTest's natural evolution cycle, please reference the latest release of Google Tests | ||
| in ``tests/CMakeLists.txt`` If we go too long without doing this, |
Owner
There was a problem hiding this comment.
This looks good! I have a question that would help me clarify for my review:
- what needs to be updated in
tests/CMakeLists.txt? Is it just a single line? Or will several changes need to happen? Maybe it would be clearer to quote the actual argument that needs to be updated in the file?
Author
There was a problem hiding this comment.
I just added the command that needs to be updated. Let me know if you think this is sufficient instruction.
Owner
Thanks for tagging me! It got to the top of my inbox this way. |
Author
|
@munkm do these instructions look sufficient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given our recent updates to the Cyclus build involving GTest, this PR modifies the instructions in CEP3 for updating GTest on release.