Skip to content

varfmt: reimplement with SSA #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaelUrman wants to merge 3 commits into
base: main
Choose a base branch
from
Open

varfmt: reimplement with SSA #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7acdfd2
varfmt: reimplement with SSA
MichaelUrman Sep 2, 2022
c0d627e
varfmt: Don't flag print-like functions
MichaelUrman Sep 2, 2022
a78437e
varfmt: handle interface calls
MichaelUrman Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 24 additions & 17 deletions varfmt/testdata/src/a/a.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,26 +22,31 @@ const (
)

func bad() {
// note: plusses, square brackets, other regex chars replaced with .

fmt.Sprintf(v1) // want "variable `v1` used for fmt.Sprintf format parameter"
passthrough(v1 + v2) // want "variable `v1 . v2` used for passthrough format parameter"
fmt.Sprintf(v1 + v2 + v3) // want "variable `v1 . v2 . v3` used for fmt.Sprintf format parameter"
fmt.Sprintf(v1 + c1) // want "variable `v1` used for fmt.Sprintf format parameter"
fmt.Sprintf((v1 + c1)) // want "non-constant expression used for fmt.Sprintf format parameter"
fmt.Sprintf(ar[0]) // want "variable `ar.0.` used for fmt.Sprintf format parameter"
fmt.Sprintf(*pv1) // want "variable `.pv1` used for fmt.Sprintf format parameter"
fmt.Sprintf(v3[:2]) // want "variable `v3` used for fmt.Sprintf format parameter"
fmt.Sprintf(v3[2:]) // want "variable `v3` used for fmt.Sprintf format parameter"
fmt.Sprintf(v3[0:2]) // want "variable `v3` used for fmt.Sprintf format parameter"
passthrough(v1 + v2) // want "variable `v1 \\+ v2` used for passthrough format parameter"
fmt.Sprintf(v1 + v2 + v3) // want "variable `v1 \\+ v2 \\+ v3` used for fmt.Sprintf format parameter"
fmt.Sprintf(v1 + c1) // want "variable `v1 \\+ c1` used for fmt.Sprintf format parameter"
fmt.Sprintf((v1 + c1)) // want "variable `\\(v1 \\+ c1\\)` used for fmt.Sprintf format parameter"
fmt.Sprintf(ar[0]) // want "variable `ar\\[0\\]` used for fmt.Sprintf format parameter"
fmt.Sprintf(*pv1) // want "variable `\\*pv1` used for fmt.Sprintf format parameter"
fmt.Sprintf(v3[:2]) // want "variable `v3\\[:2\\]` used for fmt.Sprintf format parameter"
fmt.Sprintf(v3[2:]) // want "variable `v3\\[2:\\]` used for fmt.Sprintf format parameter"
fmt.Sprintf(v3[0:2]) // want "variable `v3\\[0:2\\]` used for fmt.Sprintf format parameter"
fmt.Sprintf(pkg.V) // want "variable `pkg.V` used for fmt.Sprintf format parameter"
lv := "lv"
fmt.Sprintf(lv)
if len(os.Args) > 2 {
lv = "lv2"
}
// TODO:should we accept conditional between two constant values?
fmt.Sprintf(lv) // want "variable `lv` used for fmt.Sprintf format parameter"
lookup := map[bool]string{false: "false", true: "true"}
fmt.Sprintf(lookup[false]) // want "variable `lookup.false.` used for fmt.Sprintf format parameter"
fmt.Sprintf(lookup[false]) // want "variable `lookup\\[false\\]` used for fmt.Sprintf format parameter"
// long literals are replaced with 'non-constant expression'
fmt.Sprintf(map[bool]string{false: "false", true: "true"}[false]) // want "non-constant expression used for fmt.Sprintf format parameter"
complicated(v1, v2, v3) // want "variable `v3` used for complicated format parameter"
fmt.Fprintf(os.Stdout, os.Args[0]) // want "variable `os.Args.0.` used for fmt.Fprintf format parameter"

complicated(v1, v2, v3) // want "variable `v3` used for complicated format parameter"
fmt.Fprintf(os.Stdout, os.Args[0]) // want "variable `os\\.Args\\[0\\]` used for fmt.Fprintf format parameter"
}

func goodf(format string, args ...interface{}) {
Expand Down Expand Up @@ -73,9 +78,11 @@ func passthrough(format string, args ...interface{}) {
}

func modifiedpassthrough(format string, args ...interface{}) {
fmt.Sprintf(format, args...)
format = "blah"
// but not after they modify the format
fmt.Sprintf(format, args...) // don't warn for passthrough format strings
format = c1
fmt.Sprintf(format, args...) // nor if set to a new constant
format = v1
// but do warn if modified to a variable
fmt.Sprintf(format, args...) // want "variable `format` used for fmt.Sprintf format parameter"
}

Expand Down
Loading