Mark imported symbols as public for Pyright compatibility#1302
Closed
ernstwi wants to merge 1 commit intomvantellingen:masterfrom
Closed
Mark imported symbols as public for Pyright compatibility#1302ernstwi wants to merge 1 commit intomvantellingen:masterfrom
ernstwi wants to merge 1 commit intomvantellingen:masterfrom
Conversation
Owner
|
Seems duplicate with #1326 Closing this for now (although this was older) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for the following Pyright rule:
The docs state that "typecheckers like Pyright" use this rule, but I don't know what standard this is based on TBH.
I ran
make formatafter adding the aliases, which split all compound imports into separate lines.