Enforce NETWORK_ACCESS_ALLOWED and NETWORK_TIMEOUT on URL.unshorten#800
Open
tesitura wants to merge 1 commit into
Open
Enforce NETWORK_ACCESS_ALLOWED and NETWORK_TIMEOUT on URL.unshorten#800tesitura wants to merge 1 commit into
tesitura wants to merge 1 commit into
Conversation
Contributor
|
Contributor
|
tesitura
force-pushed
the
fix/enforce-network-access-allowed
branch
from
dc7e854 to
c834c18
Compare
|
Great catch @tesitura ! I'm not sure if these options are well documented in the mvt.re website and in the help flag on mvt. I can take a look in the code to check but just arising this conversation. CC: @besendorf Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #799
Short circuit
unshorten()when env variable NETWORK_ACCESS_ALLOWED is False, and apply NETWORK_TIMEOUT to the HEAD request.