-
Notifications
You must be signed in to change notification settings - Fork 62
Closed
Description
This should be a fairly straight forward change and should not effect the UI or functionality of the component. It's what we'd consider a "no harm" change. Here's what you need to do:
- Fork the repo
- run
npm install - run
npm run demo. This will open up a new browser window with demos of each component. It will refresh whenever you save changes to the files in thesrcdirectory. - open up
src/components/Modal - On line 23, add
className='mx-modal'before thestyleprop declaration. - On line 24, add
className='mx-modal-scrim'before theonClickprop declaration. - On line 25, add
className='mx-modal-content'before thestyleprop declaration. - On line 27, add
className='mx-modal-close'on it's own line, before theonClickprop declaration. - Open the demo and make sure your changes didn't break the Modal component.
- run
eslint srcto check for syntax and style errors. Fix the errors as needed. - Commit your changes to the
src/directory - Push your changes to your fork
- Create a PR and include
Fixes #31in the message - Get merged and celebrate 🎉