Open
Conversation
Owner
|
You are correct, but I believe it's actually a mistake in the logic. It seems that after loading the mxwebmail TXT record, we're setting it as imap_host regardless of it's presence on the whitelist. Which was actually the reason for that line, but I never followed through. Going to test a bit to confirm that I'm not going back and reading the code wrong, that I'm not forgetting something, and see what the right next move is. |
Author
|
The whitelist is checked in the other method. You actually resolve the hostname two times currently. I checked that before, because I also suspected that missing check. |
Author
|
Line 138 in 0c8592c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.