first stab at correcting cpu and memory counts when using custom offe… #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcarbone
reviewed
Sep 13, 2018
| sc.setJoinParameters("offerings", "accountId", accountId); | ||
| sc.setJoinParameters("offerings", "type", VirtualMachine.Type.User); | ||
| sc.setJoinParameters("offerings", "state", new Object[] {State.Destroyed, State.Error, State.Expunging}); | ||
| sc.setJoinParameters("offerings", "displayVm", 1); |
There was a problem hiding this comment.
What does this field actually mean? Is it used to hide "system" vms, or vms created by a root admin on behalf of the account? At first glance it would seem that we would want to include all VM's, not just those with the displayVm flag switched.
Author
There was a problem hiding this comment.
It's an arbitrary name to reference when assigning where clause parameters below that. The join is on vm_instance treacle ultimately, so that's suitable shorthand.
Author
There was a problem hiding this comment.
Crap, I didn't change it below to vms
|
lgtm |
When using custom offerings where cpu and memory are specified with user_vm_details, these totals wouldn't be correctly reflected in resource_count table. This should correct that.
nathanejohnson
force-pushed
the
bug/fixCPUAndMemoryCounts
branch
from
089675b to
5c5cefb
Compare
|
@nathanejohnson was this one merged with something else or does it still need to be done? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.