🧹 remove misleading dead_code allowance on GitlabProjectEvent#100
🧹 remove misleading dead_code allowance on GitlabProjectEvent#100
Conversation
Removed #[allow(dead_code)] from GitlabProjectEvent and GitlabEventNote in src/models.rs. These attributes were misleading as these structs are actively used in the polling logic to handle bot mentions. Ran cargo fmt to ensure consistent formatting. Co-authored-by: myaple <10523487+myaple@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Removed struct-level #[allow(dead_code)] from GitlabProjectEvent, GitlabEventNote, GitlabCommit, LabelKnowledge, and LabelOperation. - Added granular #[allow(dead_code)] to specifically unused fields and variants to accurately reflect code usage. - Ran cargo fmt --all. These changes improve code health by allowing the compiler to track the usage of members while still suppressing warnings for API-only fields. Co-authored-by: myaple <10523487+myaple@users.noreply.github.com>
- Replaced over-broad struct-level #[allow(dead_code)] with granular field-level and variant-level allowances in src/models.rs, src/gitlab.rs, and src/triage.rs. - This accurately identifies reachable code (like note fields in events) while satisfying clippy for unused API model members. - Ran cargo fmt --all. Co-authored-by: myaple <10523487+myaple@users.noreply.github.com>
1 participant
This change removes the
#[allow(dead_code)]attribute fromGitlabProjectEventandGitlabEventNotestructs insrc/models.rs. These attributes were misleading because both structs are actively used insrc/polling.rsfor processing GitLab note events and detecting bot mentions.I also ran
cargo fmt --allto ensure the codebase remains correctly formatted.PR created automatically by Jules for task 13124981988551692916 started by @myaple