feat(test): standardise use of `share` suite & `_mapdata` state by myii · Pull Request #302 · myii/ssf-formula

myii · 2021-03-23T10:58:21Z

Various objectives met with this PR:

Use the share suite across all formulas.
Use the _mapdata state across all formulas (run in CI for map.jinja dump, verification can be tackled later).
Centralise the Gemfile template and update kitchen-docker comment.
Update .rubocop.yml with regards to ExcludedMethods => IgnoredMethods.
Clear up the use of YAML node anchors in formulas.yaml.

Already tested these changes across all formulas (more than once), the last run being:

https://saltstack-formulas.zulipchat.com/#narrow/stream/239693-CI/topic/share-suite-and-mapdata.2F2021-W12a

While pushing these changes, took this opportunity to fix the missing rubocop entry in .pre-commit-config.yaml in the following formulas (where *travis_do_not_use_single_job_for_linters was removed in #293):

iptables
syslog-ng
vault

``` Warning: obsolete parameter `ExcludedMethods` (for `Metrics/BlockLength`) found in .rubocop.yml `ExcludedMethods` has been renamed to `IgnoredMethods`. ```

* Automated using myii/ssf-formula#302

myii · 2021-03-23T21:41:40Z

🎉 This PR is included in version 1.254.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

myii force-pushed the feat/use-share-suite-across-all-formulas branch from ac8ca71 to c7f4726 Compare March 23, 2021 19:50

myii added 9 commits March 23, 2021 21:11

feat(test/share): use share suite across all formulas

b65e7f8

feat(_mapdata): add main files to formulas by default

50963f8

feat(_mapdata): add state to formulas with specific state_top

1677818

feat(_mapdata): add _mapdata to all formulas

4c39519

feat(gemfile): use single Jinja template for all formulas

e4d7e45

fix(gemfile): update comment about using git for kitchen-docker gem

65301e1

feat(rubocop): rename obsolete ExcludedMethods => IgnoredMethods

0ec59c5

``` Warning: obsolete parameter `ExcludedMethods` (for `Metrics/BlockLength`) found in .rubocop.yml `ExcludedMethods` has been renamed to `IgnoredMethods`. ```

refactor(formulas): remove/merge YAML node anchors re: platforms*

f1565ba

refactor(formulas): remove/merge YAML node anchors re: supports

b38763b

myii changed the title ~~feat(test/share): use share suite across all formulas~~ feat(test): standardise use of share suite & _mapdata state Mar 23, 2021

myii added a commit to saltstack-formulas/apache-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

e7c2d20

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/apt-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

9f6b2b1

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/apt-cacher-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

91760d6

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/arvados-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

e804dd1

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/bind-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

3cb26c0

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/cert-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

b372c37

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/chrony-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

e2d97f9

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/collectd-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

f461b84

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/consul-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

13db8f4

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/cron-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

73b9643

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/deepsea-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

babe071

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/devstack-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

628bee8

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/dhcpd-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

cf811ec

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/django-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

56cb1ec

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/docker-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

69d7e65

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/eclipse-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

17fed2f

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/epel-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

bd9b1ba

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/exim-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

96a7a85

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/fail2ban-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

920bb7d

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/jetbrains-webstorm-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

6b760d3

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/keepalived-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

89986bf

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/letsencrypt-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

1105cb8

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/libvirt-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

c1ab958

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/locale-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

0503b56

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/logrotate-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

650cfad

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/lvm-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

35a2f80

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/lynis-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

8ae9e88

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/maven-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

4cdf7d8

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/mongodb-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

82a3b26

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/mysql-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

c11750c

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/nfs-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

b3d113a

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/nginx-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

8ea3c82

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/nifi-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

f971f99

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/node-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

42f8881

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/ntp-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

a23eff8

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/nut-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

d161eb0

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/openldap-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

470766e

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/openntpd-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

51ad04d

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/openssh-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

35a2124

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/openvpn-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

c247b83

* Automated using myii/ssf-formula#302

myii force-pushed the feat/use-share-suite-across-all-formulas branch from c7f4726 to b38763b Compare March 23, 2021 21:31

myii added a commit to saltstack-formulas/packages-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

79257d5

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/php-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

bf6a758

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/postfix-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

4c394a7

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/postgres-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

fc53d97

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/powerdns-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

0b6da37

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/proftpd-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

22c784e

* Automated using myii/ssf-formula#302

myii added a commit to saltstack-formulas/prometheus-formula that referenced this pull request Mar 23, 2021

test: standardise use of share suite & _mapdata state [skip ci]

2b38c9e

* Automated using myii/ssf-formula#302

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(test): standardise use of `share` suite & `_mapdata` state#302

feat(test): standardise use of `share` suite & `_mapdata` state#302
myii merged 9 commits intomasterfrom
feat/use-share-suite-across-all-formulas

myii commented Mar 23, 2021 •

edited

Loading

Uh oh!

myii commented Mar 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

myii commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

myii commented Mar 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

myii commented Mar 23, 2021 •

edited

Loading