Skip to content

fix: remove prompt_file from test oracle payload#1011

Merged
myakove merged 2 commits intomainfrom
remove-prompt-file
Mar 2, 2026
Merged

fix: remove prompt_file from test oracle payload#1011
myakove merged 2 commits intomainfrom
remove-prompt-file

Conversation

@rnetser
Copy link
Copy Markdown
Collaborator

@rnetser rnetser commented Mar 2, 2026

Summary

  • Remove prompt_file field from test oracle payload
  • The oracle service handles TESTS_ORACLE.md on its own
  • Remove related tests

Test plan

  • All 1313 tests pass
  • 90.64% coverage
  • No references to prompt_file or TESTS_ORACLE anywhere in codebase

Summary by CodeRabbit

  • Refactor

    • Removed support for per-repository TESTS_ORACLE.md prompt customization (prompt_file injection removed).
  • Documentation

    • Removed documentation and example comments referencing TESTS_ORACLE.md configuration.
  • Tests

    • Removed tests and test fixtures covering inclusion/omission of TESTS_ORACLE.md in payloads.

The oracle service handles TESTS_ORACLE.md on its own via the
repo clone. Remove the unused prompt_file payload field and
related filesystem checks.
@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Remove prompt_file from test oracle payload

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Remove prompt_file field from test oracle payload
• Oracle service now handles TESTS_ORACLE.md independently
• Remove unused os import and filesystem checks
• Delete related tests for prompt file handling
• Update documentation to reflect simplified behavior
Diagram
flowchart LR
  A["Test Oracle Integration"] -->|Previously| B["Check for TESTS_ORACLE.md<br/>Pass prompt_file path"]
  A -->|Now| C["Oracle handles<br/>TESTS_ORACLE.md directly"]
  B -->|Removed| D["os.path.isfile checks<br/>payload prompt_file field"]
  C -->|Simplified| E["Cleaner payload<br/>No filesystem logic"]
Loading

Grey Divider

File Changes

1. webhook_server/libs/test_oracle.py 🐞 Bug fix +0/-7

Remove prompt_file handling from oracle call

• Remove import os statement (no longer needed)
• Delete filesystem check for TESTS_ORACLE.md file existence
• Remove prompt_file payload field assignment
• Remove debug logging for oracle prompt path

webhook_server/libs/test_oracle.py


2. webhook_server/tests/test_test_oracle.py 🧪 Tests +0/-53

Remove prompt file related test cases

• Remove clone_repo_dir from mock webhook setup
• Delete test_oracle_md_included_in_payload test case
• Delete test_oracle_md_not_included_when_missing test case
• Simplify test fixtures by removing path-related mocks

webhook_server/tests/test_test_oracle.py


3. CLAUDE.md 📝 Documentation +0/-2

Remove prompt customization documentation

• Remove documentation about TESTS_ORACLE.md prompt customization
• Simplify feature description for test oracle integration

CLAUDE.md


View more (3)
4. README.md 📝 Documentation +1/-1

Simplify test oracle feature description

• Remove mention of per-repo TESTS_ORACLE.md prompt customization
• Simplify PR Test Oracle feature description

README.md


5. examples/.github-webhook-server.yaml 📝 Documentation +0/-1

Remove prompt customization comment

• Remove comment about placing TESTS_ORACLE.md in repository root
• Simplify test-oracle configuration documentation

examples/.github-webhook-server.yaml


6. examples/config.yaml 📝 Documentation +0/-2

Remove prompt customization comments

• Remove comment about TESTS_ORACLE.md prompt customization in global config
• Remove comment about TESTS_ORACLE.md in repository-specific test-oracle config

examples/config.yaml


Grey Divider

Qodo Logo

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a288d73 and 2ae2e65.

📒 Files selected for processing (1)
  • README.md

Walkthrough

Removed the TESTS_ORACLE.md prompt customization feature: deleted docs/comments referencing it, removed repository-file detection and prompt_file injection from the implementation, and removed related tests.

Changes

Cohort / File(s) Summary
Documentation
CLAUDE.md, README.md
Removed lines describing per-repo TESTS_ORACLE.md prompt customization.
Configuration examples
examples/.github-webhook-server.yaml, examples/config.yaml
Deleted inline comments instructing users to place TESTS_ORACLE.md in the repo to customize AI prompts.
Implementation
webhook_server/libs/test_oracle.py
Removed code that detected TESTS_ORACLE.md in cloned repos and injected prompt_file into payloads; eliminated related os filesystem checks/imports.
Tests
webhook_server/tests/test_test_oracle.py
Removed mock assignment of clone_repo_dir and deleted two tests that validated inclusion/omission of TESTS_ORACLE.md (test_oracle_md_included_in_payload, test_oracle_md_not_included_when_missing).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

size/S, can-be-merged

Suggested reviewers

  • myakove
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: remove prompt_file from test oracle payload' clearly and specifically describes the main change across all files in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-prompt-file

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented Mar 2, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@myakove-bot
Copy link
Copy Markdown
Collaborator

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: Disabled for this repository
  • Pre-commit Checks: pre-commit runs automatically if .pre-commit-config.yaml exists
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: All label categories are enabled (default configuration)

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest python-module-install - Test Python package installation
  • /retest pre-commit - Run pre-commit hooks and checks
  • /retest conventional-title - Validate commit message format
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 1 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No WIP, hold, conflict labels
  5. Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

  • myakove
  • rnetser

Reviewers:

  • myakove
  • rnetser
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
  • automerge

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is automatically removed on each new commit
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@myakove
Copy link
Copy Markdown
Collaborator

myakove commented Mar 2, 2026

/lgtm
/approve

Comment thread CLAUDE.md
@rnetser
Copy link
Copy Markdown
Collaborator Author

rnetser commented Mar 2, 2026

/build-and-push-container

@myakove-bot
Copy link
Copy Markdown
Collaborator

New container for ghcr.io/myk-org/github-webhook-server:pr-1011 published

@rnetser
Copy link
Copy Markdown
Collaborator Author

rnetser commented Mar 2, 2026

/verified

@myakove myakove merged commit 5335d9e into main Mar 2, 2026
9 checks passed
@myakove myakove deleted the remove-prompt-file branch March 2, 2026 12:19
@myakove-bot
Copy link
Copy Markdown
Collaborator

Successfully removed PR tag: ghcr.io/myk-org/github-webhook-server:pr-1011.

@myakove-bot
Copy link
Copy Markdown
Collaborator

New container for ghcr.io/myk-org/github-webhook-server:latest published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants