Skip to content

use uv instead of poetry#579

Merged
myakove merged 4 commits intomainfrom
uv
Oct 9, 2024
Merged

use uv instead of poetry#579
myakove merged 4 commits intomainfrom
uv

Conversation

@myakove
Copy link
Copy Markdown
Collaborator

@myakove myakove commented Oct 7, 2024

Summary by CodeRabbit

  • New Features

    • Transitioned project configuration from Poetry to Hatch for dependency management.
    • Added support for multiple Python versions (3.8 to 3.12) and essential development tools.
    • Introduced new environment variables for user binaries and installation directories.
    • Added a new script for enhanced installation during the build process.
  • Improvements

    • Updated commands for running the server and Python scripts to utilize a new execution method with uv.
    • Enhanced project metadata, including updated versioning and author information.
  • Bug Fixes

    • Adjusted commands for running tests to ensure compatibility with the new setup.
  • Chores

    • Removed the version file from the repository, centralizing versioning in the configuration.
    • Updated the base image used for command execution in the container.

@myakove-bot
Copy link
Copy Markdown
Collaborator

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
    • You can add extra args to the Podman build command
      • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest build-container: Retest build-container
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 7, 2024

Walkthrough

The pull request updates the Dockerfile, entrypoint.sh, and pyproject.toml to enhance functionality and transition dependency management from Poetry to Hatch. The Dockerfile now includes multiple Python versions, new environment variables, and a script executed during the build process. The entrypoint.sh script has been modified to change command execution from poetry to uv. The pyproject.toml has undergone a complete restructuring, updating project metadata and dependencies to align with the new build system.

Changes

File Change Summary
Dockerfile Updated to streamline package installations, added Python versions 3.8-3.12, introduced USER_CARGO_DIR, updated PATH, executed a new installation script, modified dependency management from Poetry to Hatch.
entrypoint.sh Modified to change command execution from poetry run to uv run for server and script execution commands.
pyproject.toml Transitioned from Poetry to Hatch configuration, updated project version and dependencies, restructured authors' information, and changed build system requirements.
tox.ini Updated to remove poetry dependency, changed commands to use uv, and retained existing environment configurations.

Possibly related PRs

  • Add docker to the container #540: The changes in this PR also involve modifications to the Dockerfile, specifically enhancing its functionality with additional Docker-related packages, which aligns with the updates made in the main PR regarding the Dockerfile.

Suggested labels

verified, size/S

Suggested reviewers

  • rnetser

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e423877 and 61a08ac.

📒 Files selected for processing (1)
  • tox.ini (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • tox.ini

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Outside diff range and nitpick comments (6)
entrypoint.sh (1)

Line range hint 1-18: Overall changes require consistency in Poetry removal

While the SERVER_RUN_CMD has been updated to remove the poetry run prefix, which aligns with the PR objective of transitioning from Poetry to uv, the script executions on lines 10 and 11 still use poetry run. This inconsistency needs to be addressed to fully implement the transition away from Poetry.

To ensure a consistent approach throughout the script:

  1. Remove all instances of poetry run.
  2. Verify that the Python environment is correctly set up to run uvicorn and the utility scripts without Poetry.
  3. Update the execution of utility scripts to use either python or make them executable, depending on your preferred approach.

These changes will help maintain consistency and fully achieve the PR objective of transitioning from Poetry to uv.

pyproject.toml (1)

64-65: UV tool configuration is good, consider additional dev-dependencies.

The addition of the UV tool configuration for managing dev-dependencies is a good practice. The inclusion of ipdb and ipython as dev-dependencies is appropriate for debugging purposes.

Consider adding other common development tools to the dev-dependencies, such as:

  • black for code formatting
  • flake8 for linting
  • mypy for static type checking
    These tools can help maintain code quality and consistency across the project.
webhook_server_container/libs/github_api.py (4)

1098-1098: LGTM! Consider adding a comment for clarity.

The change from directly using Python to using uvx aligns with the PR objective of transitioning from Poetry to UV. This modification looks good.

Consider adding a brief comment explaining the use of 'uvx', such as:

# Use uvx to run tox with the specified Python version
cmd = f"uvx --python {self.tox_python_version} {TOX_STR}"

This will help future maintainers understand the reason for using 'uvx'.


1125-1125: LGTM! Consider adding a comment for consistency.

The change to use uvx for running pre-commit is consistent with the PR objective and the changes in the _run_tox method. This modification looks good.

For consistency with the _run_tox method and to improve maintainability, consider adding a brief comment explaining the use of 'uvx', such as:

# Use uvx to run pre-commit
cmd = f"uvx {PRE_COMMIT_STR} run --all-files"

This will help maintain consistency in code documentation.


Line range hint 1-1639: Consider a broader review for remaining Poetry references

The changes in this file successfully implement the use of 'uv' (via 'uvx') in place of Poetry for running tox and pre-commit. However, given the PR objective to transition from Poetry to UV, it might be beneficial to conduct a broader review of the codebase.

Consider running a search across the entire codebase for any remaining references to Poetry that might need updating. This will ensure a complete transition to UV. You can use a command like:

rg 'poetry' --type python

This will help identify any other files or code segments that might need attention in this transition.


Line range hint 1-1639: Consider refactoring for improved maintainability

While not directly related to the PR objective, I noticed that this file is quite long (1639 lines) and contains numerous methods, some of which are quite complex. This can make the code harder to maintain and understand.

Consider refactoring this file by splitting it into smaller, more focused modules. For example, you could separate the GitHub-specific operations, Jira integrations, and container build processes into their own modules.

As an example of a method that might benefit from refactoring, consider the check_if_can_be_merged method (around line 1300). It's quite long and handles multiple responsibilities. You could potentially break it down into smaller, more focused methods, each handling a specific aspect of the merge check.

This refactoring would improve code readability, maintainability, and make it easier to test individual components of the system.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9b4958a and 62f151d.

📒 Files selected for processing (5)
  • Dockerfile (2 hunks)
  • entrypoint.sh (1 hunks)
  • pyproject.toml (1 hunks)
  • tox.ini (1 hunks)
  • webhook_server_container/libs/github_api.py (2 hunks)
🧰 Additional context used
🔇 Additional comments (10)
tox.ini (2)

13-15: LGTM! Transition from poetry to uv looks good.

The changes align with the PR objective to use uv instead of poetry. The allowlist_externals configuration is correctly added to allow the use of the external uv command.

To ensure the smooth transition, please verify that uv is properly installed and configured in your CI/CD pipeline. You can add a step in your CI workflow to check the uv installation:


11-15: Verify dependency management with uv

The deps line has been removed from the [testenv:pytest] section. With the transition to uv, ensure that all required dependencies are properly managed, possibly through a pyproject.toml file or another mechanism supported by uv.

To confirm that all necessary dependencies are available, you can add a step in your CI pipeline to list installed packages:

Also, verify that a pyproject.toml file exists and contains the necessary dependency information:

entrypoint.sh (1)

5-5: LGTM! Verify the Python environment setup.

The removal of poetry run from SERVER_RUN_CMD aligns with the PR objective of transitioning from Poetry to uv. This change suggests that the Python environment is now managed differently.

To ensure the environment is correctly set up, please run the following script:

pyproject.toml (5)

19-53: Project metadata and dependencies look good, but please clarify the version jump.

The transition to Hatch and the updated project metadata look good. The dependencies are well-defined with version specifications. However, there's a significant version jump from 0.0.0 to 1.0.68.

Could you please clarify the reasoning behind this major version change? It would be helpful to understand if this represents a significant milestone or if it's aligning with an existing versioning scheme.


55-56: Hatch build configuration looks good, verify package name.

The Hatch build configuration for the wheel target is correctly set up.

Please confirm that "webhook_server_container" is indeed the correct package name for your project. If it's not, update it to match your project's main package name.


58-62: Project URLs are correctly updated and maintained.

The project URLs have been successfully migrated to the new [project.urls] format while maintaining the same content. This change is consistent with the transition from Poetry to Hatch.


67-69: Build system configuration correctly updated for Hatch.

The build system configuration has been successfully updated to use Hatch. The use of "hatchling" as the build backend is correct and consistent with Hatch-based projects.


19-69: Overall, the transition to Hatch is well-implemented.

The changes in this file successfully transition the project from Poetry to Hatch. The project metadata, dependencies, build configuration, and other sections have been appropriately updated. The new structure is consistent with Hatch-based projects and should provide a solid foundation for your development workflow.

A few points to address:

  1. Clarify the significant version jump from 0.0.0 to 1.0.68.
  2. Verify that "webhook_server_container" is the correct package name.
  3. Consider adding more development tools to the dev-dependencies.

Once these points are addressed, the configuration should be ready for use.

Dockerfile (2)

30-33: Adding USER_CARGO_DIR to PATH

The addition of USER_CARGO_DIR and updating the PATH variable ensures that executables installed via Cargo are accessible. This is appropriate for the uv installation.


66-66: Updating COPY command to include uv.lock

Including uv.lock in the COPY command ensures that dependencies are correctly installed using uv. This change aligns with the transition from poetry to uv.

Comment thread entrypoint.sh Outdated
Comment thread entrypoint.sh Outdated
Comment thread Dockerfile Outdated
@myakove
Copy link
Copy Markdown
Collaborator Author

myakove commented Oct 7, 2024

/retest tox

@myakove
Copy link
Copy Markdown
Collaborator Author

myakove commented Oct 7, 2024

/retest python-module-install

rnetser
rnetser previously approved these changes Oct 7, 2024
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (4)
entrypoint.sh (1)

10-11: LGTM! Consider using a loop for multiple script executions.

The changes from 'poetry run python' to 'uv run' for executing Python scripts are correct and align with the PR objective. However, to improve maintainability and reduce repetition, consider using a loop to execute multiple scripts.

Here's a suggested refactoring to use a loop:

-uv run webhook_server_container/utils/github_repository_settings.py
-uv run webhook_server_container/utils/webhook.py
+for script in github_repository_settings.py webhook.py; do
+    uv run webhook_server_container/utils/${script}
+done

This approach makes it easier to add or remove scripts in the future without modifying the loop structure.

.release-it.json (1)

20-20: LGTM! Consider minor formatting improvement.

The change to pushArgs is correct and maintains the same functionality. However, for consistency with JSON formatting conventions, consider using a multi-line array format for better readability:

-    "pushArgs": ["--follow-tags"],
+    "pushArgs": [
+      "--follow-tags"
+    ],

This format is more scalable if additional arguments need to be added in the future.

webhook_server_container/libs/github_api.py (2)

Line range hint 1575-1580: Use uvx instead of uv for consistency

In line 1575, the command uses uv:

rc, out, err = self._run_in_container(command="uv tool install .")

For consistency with other commands that utilize uvx, consider using uvx here to maintain uniformity across the codebase.

Apply this diff to ensure consistency:

-rc, out, err = self._run_in_container(command="uv tool install .")
+rc, out, err = self._run_in_container(command="uvx tool install .")

Line range hint 1697-1707: Remove unnecessary space when env is empty

In the command construction at line 1697:

f"--rm {env if env else ''} --entrypoint bash quay.io/myakove/github-webhook-server:uv -c"

If env is empty, this results in an extra space between --rm and --entrypoint. While this may not affect execution, it can be cleaner to avoid unintended spaces.

Apply this diff to refine the string formatting:

-f"--rm {env if env else ''} --entrypoint bash quay.io/myakove/github-webhook-server:uv -c"
+f"--rm{f' {env}' if env else ''} --entrypoint bash quay.io/myakove/github-webhook-server:uv -c"

This adjustment ensures that there are no extra spaces when env is not provided.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 62f151d and 72bdc37.

⛔ Files ignored due to path filters (2)
  • poetry.lock is excluded by !**/*.lock
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • .release-it.json (2 hunks)
  • VERSION (0 hunks)
  • entrypoint.sh (1 hunks)
  • webhook_server_container/libs/github_api.py (4 hunks)
💤 Files with no reviewable changes (1)
  • VERSION
🧰 Additional context used
🔇 Additional comments (2)
.release-it.json (1)

41-42: Approve changes to @release-it/bumper configuration. Verify project structure impact.

The changes to the @release-it/bumper plugin configuration look good. They indicate a shift from using a separate VERSION file to managing the version in the pyproject.toml file, which is a common practice in modern Python projects.

Let's verify the impact of this change on the project structure:

This script will help ensure that the project structure has been updated consistently with the new configuration.

webhook_server_container/libs/github_api.py (1)

1125-1127: Confirm uvx usage for Pre-Commit command

The updated command leverages uvx to run Pre-Commit checks:

cmd = f"uvx {PRE_COMMIT_STR} run --all-files"

This change aligns with the new execution method and appears consistent with other updates.

Comment thread entrypoint.sh
Comment thread webhook_server_container/libs/github_api.py Outdated
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (5)
Dockerfile (2)

30-30: LGTM! Consider adding a comment for clarity.

The addition of USER_CARGO_DIR and its inclusion in the PATH is appropriate for the transition to uv. This ensures that Rust-based tools are accessible throughout the container.

Consider adding a brief comment explaining the purpose of USER_CARGO_DIR, such as:

# Directory for Rust-based tools (e.g., uv)
ENV USER_CARGO_DIR="/root/.cargo/bin"

Also applies to: 33-33


40-40: LGTM! Consider using multi-line RUN for consistency.

The installation of tox using uv is correct and aligns with the transition to uv for dependency management.

For consistency with other multi-line RUN commands in this Dockerfile, consider using a multi-line format:

RUN set -x \
    && uv tool install tox --with tox-uv

This format is more consistent with the style used elsewhere in the file and allows for easier addition of related commands in the future if needed.

webhook_server_container/libs/github_api.py (3)

1098-1101: LGTM! Consider adding a comment for clarity.

The change from using a direct Python command to uv run is consistent with the PR objective of replacing poetry with uv. This change should maintain the functionality while adapting to the new tool.

Consider adding a brief comment explaining the use of uv run for better code readability:

-cmd = f"uv run --python {self.tox_python_version} {TOX_STR}"
+# Use uv to run tox with the specified Python version
+cmd = f"uv run --python {self.tox_python_version} {TOX_STR}"

1575-1575: LGTM! Consider consistency in uv usage.

The change to use uvx pip install is consistent with the PR objective of replacing poetry with uv. This should maintain the functionality while adapting to the new tool.

For consistency across the codebase, consider using the same uv command style as in the _run_tox method. If there's no specific reason to use uvx here, you might want to change it to uv run:

-rc, out, err = self._run_in_container(command="uvx pip install .")
+rc, out, err = self._run_in_container(command="uv run pip install .")

If there is a reason for using uvx instead of uv run, it would be helpful to add a comment explaining the difference.


1697-1697: LGTM! Consider adding a comment for clarity.

The update to use the :uv tagged image is consistent with the PR objective of replacing poetry with uv. This ensures that the container used for running commands has the uv tool available.

Consider adding a brief comment explaining the use of the :uv tagged image for better code readability:

-f"--rm {env if env else ''} --entrypoint bash quay.io/myakove/github-webhook-server:uv -c"
+# Use the uv-enabled image for running commands
+f"--rm {env if env else ''} --entrypoint bash quay.io/myakove/github-webhook-server:uv -c"
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 690f47c and 10fe505.

📒 Files selected for processing (2)
  • Dockerfile (2 hunks)
  • webhook_server_container/libs/github_api.py (5 hunks)
🧰 Additional context used
🔇 Additional comments (5)
Dockerfile (3)

35-39: Excellent implementation of the uv installer!

The use of curl to download the uv installer script, followed by its execution and removal, is a secure and efficient approach. This implementation correctly addresses the previous review comment and follows Docker best practices.


Line range hint 1-73: Overall, excellent implementation of the transition to uv!

The changes in this Dockerfile successfully implement the transition from Poetry to uv as per the PR objectives. Key points:

  1. The addition of USER_CARGO_DIR and its inclusion in PATH ensures proper setup for Rust-based tools.
  2. The uv installer is downloaded and executed securely, following best practices.
  3. Tox is installed using uv, aligning with the new dependency management approach.
  4. The COPY command has been updated to include uv.lock, reflecting the change in dependency management.

These changes collectively achieve the goal of replacing Poetry with uv in the project's container setup. The implementation is thorough and considers important aspects such as security and consistency with existing practices.

To fully complete the transition, ensure that all references to Poetry have been removed from other parts of the project, and that the uv.lock file is being generated and maintained correctly in your development workflow.


67-67: LGTM! Verify uv.lock generation.

The update to include uv.lock instead of poetry.lock in the COPY command is correct and aligns with the transition to uv for dependency management.

To ensure the uv.lock file is being generated correctly, please run the following verification script:

This script will confirm the presence of uv.lock and check for any remaining references to poetry.lock that might need updating.

✅ Verification successful

Verified! The uv.lock file exists and is correctly configured, and there are no remaining references to poetry.lock in the project.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the existence and content of uv.lock file

if [ -f "uv.lock" ]; then
    echo "uv.lock file exists."
    echo "First few lines of uv.lock:"
    head -n 5 uv.lock
else
    echo "Error: uv.lock file not found."
    exit 1
fi

# Check if there are any references to poetry.lock remaining in the project
if grep -r "poetry.lock" .; then
    echo "Warning: Found references to poetry.lock in the project. Please review and update these."
fi

Length of output: 347

webhook_server_container/libs/github_api.py (2)

Line range hint 1-1897: Overall, the changes look good with some minor suggestions for improvement.

The modifications to replace poetry with uv are consistently implemented across the file. The core functionality of the methods remains intact while adapting to the new tool. Here's a summary of the changes and suggestions:

  1. In _run_tox, uv run is used to execute tox.
  2. In _run_pre_commit and _run_install_python_module, uvx is used instead of uv run.
  3. The base container image has been updated to include the :uv tag.

Consider addressing the following points:

  1. Clarify the reason for using uvx in some methods and uv run in others.
  2. Add comments to explain the use of uv commands and the uv-enabled container image.
  3. Ensure consistency in uv usage across the file, or document the reasons for any differences.

These changes have successfully transitioned the project from poetry to uv while maintaining the existing functionality.


1125-1125: LGTM! Clarification needed on uvx usage.

The change to use uvx for running pre-commit is consistent with the PR objective of replacing poetry with uv. This should maintain the functionality while adapting to the new tool.

Could you clarify why uvx is used here instead of uv run as in the _run_tox method? Is there a specific reason for this difference?

To verify the consistency of uvx usage, let's check other occurrences in the file:

✅ Verification successful

LGTM! uvx is consistently used across the file.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

rg "uvx" webhook_server_container/libs/github_api.py

Length of output: 326

@myakove
Copy link
Copy Markdown
Collaborator Author

myakove commented Oct 7, 2024

/wip

@myakove-bot myakove-bot added the wip label Oct 7, 2024
@myakove-bot myakove-bot changed the title use uv instead of poetry WIP: use uv instead of poetry Oct 7, 2024
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 10fe505 and f55acde.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • Dockerfile (2 hunks)
  • entrypoint.sh (1 hunks)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • Dockerfile
  • entrypoint.sh
🧰 Additional context used
🔇 Additional comments (2)
pyproject.toml (2)

58-62: LGTM! URLs updated correctly.

The project URLs have been correctly updated to use the new [project.urls] format, which aligns with the transition to the new build system. The provided URLs seem appropriate for the project.


55-56: LGTM! Please verify the package name.

The Hatch build configuration looks correct. However, please verify that 'webhook_server_container' is the correct package name for your project.

Run the following script to check the project structure and ensure the package name is correct:

✅ Verification successful

Verified the package name. 'webhook_server_container' is a valid Python package.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check project structure
echo "Project structure:"
tree -L 2 -d

echo "\nPython files in root directory:"
find . -maxdepth 1 -name "*.py"

echo "\nSetup files:"
find . -maxdepth 1 -name "setup.py" -o -name "setup.cfg"

Length of output: 353


Script:

#!/bin/bash
# List contents of 'webhook_server_container' to verify it is a Python package
echo "Listing contents of 'webhook_server_container':"
ls -R webhook_server_container

echo "\nChecking for '__init__.py' files to confirm it's a Python package:"
find webhook_server_container -type f -name "__init__.py"

Length of output: 848

Comment thread pyproject.toml
Comment thread pyproject.toml
Comment thread pyproject.toml
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
Dockerfile (3)

Line range hint 4-28: LGTM! Consider using specific package versions for reproducibility.

The consolidation of package installations into a single RUN command is a good practice, reducing the number of layers in the Docker image. The inclusion of multiple Python versions provides flexibility for development and testing.

Consider specifying versions for critical packages to ensure reproducibility. For example:

-  && dnf -y install python3.8 \
+  && dnf -y install python3.8-3.8.x \

Replace 'x' with the specific minor version you want to use.


29-30: LGTM! Consider adding a comment for clarity.

The introduction of UV_INSTALL_DIR and the update to PATH are appropriate for the shift towards using 'uv' for dependency management.

Consider adding a comment to explain the purpose of these environment variables:

+# Set up environment for uv package manager
 ENV UV_INSTALL_DIR="/root/.local"
 ENV PATH="$PATH:$USER_BIN_DIR"

Line range hint 54-67: LGTM! Consider using a loop for more concise installation.

The installation of tox for each Python version ensures compatibility across different environments, which is excellent.

To make the installation process more concise and easier to maintain, consider using a loop:

-RUN python3.8 -m ensurepip \
-  && python3.9 -m ensurepip \
-  && python3.10 -m ensurepip \
-  && python3.11 -m ensurepip \
-  && python3.12 -m ensurepip \
-  && python3.8 -m pip install tox \
-  && python3.9 -m pip install tox \
-  && python3.10 -m pip install tox \
-  && python3.11 -m pip install tox \
-  && python3.12 -m pip install tox
+RUN for version in 3.8 3.9 3.10 3.11 3.12; do \
+      python$version -m ensurepip && \
+      python$version -m pip install tox; \
+    done

This change reduces repetition and makes it easier to add or remove Python versions in the future.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f55acde and e423877.

📒 Files selected for processing (1)
  • Dockerfile (3 hunks)
🧰 Additional context used
🔇 Additional comments (2)
Dockerfile (2)

40-43: Great job implementing the suggested change!

The use of curl to download the uv installer script, followed by its execution and removal, is an excellent implementation of Docker best practices. This approach ensures proper caching and allows for better control over the download process.


68-68: LGTM! Verify uv.lock file existence and contents.

The change from poetry.lock to uv.lock correctly reflects the transition to using uv for dependency management.

To ensure the uv.lock file is present and contains the expected dependencies, run the following script:

This script will verify the existence of the uv.lock file, display its first few lines, and check if pyproject.toml contains uv configuration.

✅ Verification successful

Verified: uv.lock file exists and is correctly referenced

The uv.lock file is present and pyproject.toml contains the necessary [tool.uv] configuration, confirming the transition to using uv for dependency management.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence and contents of uv.lock file

# Test: Check if uv.lock exists
if [ -f uv.lock ]; then
    echo "uv.lock file exists."
    # Display the first few lines of uv.lock to verify its contents
    head -n 10 uv.lock
else
    echo "Error: uv.lock file not found."
    exit 1
fi

# Test: Check if pyproject.toml references uv
if grep -q "\[tool.uv\]" pyproject.toml; then
    echo "pyproject.toml contains uv configuration."
else
    echo "Warning: pyproject.toml does not contain uv configuration."
fi

Length of output: 468

@myakove
Copy link
Copy Markdown
Collaborator Author

myakove commented Oct 9, 2024

/wip cancel

@myakove-bot myakove-bot removed the wip label Oct 9, 2024
@myakove-bot myakove-bot changed the title WIP: use uv instead of poetry use uv instead of poetry Oct 9, 2024
@myakove
Copy link
Copy Markdown
Collaborator Author

myakove commented Oct 9, 2024

/verified

@myakove myakove merged commit 57be48d into main Oct 9, 2024
@myakove myakove deleted the uv branch October 9, 2024 10:19
@myakove-bot
Copy link
Copy Markdown
Collaborator

New container for quay.io/myakove/github-webhook-server:latest published

myakove added a commit that referenced this pull request Oct 14, 2024
* chore(deps): update poetry-deps (#415)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* enable to run tox with specific python version

* [pre-commit.ci] pre-commit autoupdate (#416)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.3.5 → v0.3.7](astral-sh/ruff-pre-commit@v0.3.5...v0.3.7)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Release 1.0.28

* chore(deps): update poetry-deps (#417)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* welcome msg: add not supported retest in repository do not have any

* poetry update

* chore(deps): update poetry-deps (#419)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#420)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.29

* chore(deps): update poetry-deps (#421)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#422)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.3.7 → v0.4.1](astral-sh/ruff-pre-commit@v0.3.7...v0.4.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* do not block merge if PR merked as mergable by github

* User can set extra required labels to set PR as ca be merged (#424)

* Release 1.0.30

* dockerfile add

* Release 1.0.31

* chore(deps): update poetry-deps (#426)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* can-be-mrged: check if pr mergeable_state is clean

* can-be-mrged: check if pr mergeable_state is clean

* can-be-mrged: remove check if pr mergeable_state is clean

* chore(deps): update poetry-deps (#430)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix reviewers per folders

* chore(deps): update poetry-deps (#433)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#432)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.1 → v0.4.2](astral-sh/ruff-pre-commit@v0.4.1...v0.4.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Support create jira issues to track PR lifecycle (#428)

* Support create jira issues to track PR lifecycle

* Add color to Jira label

* Add logs for jira actions

* PR lifecycle in jira

* Open story under epic if provided

* Fix duplicate log filter

* Update readme

* jira: add repo name to title

* Release 1.0.32

* parent_commiter should be commiter of last commit

* chore(deps): update poetry-deps (#435)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency pyhelper-utils to ^0.0.14 (#434)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.33

* chore(deps): update poetry-deps (#437)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* add last_commiter var

* set jira assignee only if user in jira mapping

* chore(deps): update dependency pyhelper-utils to ^0.0.15 (#436)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

* Fix return in init

* Release 1.0.34

* chore(deps): update poetry-deps (#438)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* set labels on private repos

* set labels on private repos

* set labels on private repos

* Release 1.0.35

* check_if_can_be_merged: check only required runs (#439)

* [pre-commit.ci] pre-commit autoupdate (#441)

updates:
- [github.com/Yelp/detect-secrets: v1.4.0 → v1.5.0](Yelp/detect-secrets@v1.4.0...v1.5.0)
- [github.com/astral-sh/ruff-pre-commit: v0.4.2 → v0.4.3](astral-sh/ruff-pre-commit@v0.4.2...v0.4.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Release 1.0.36

* Fix fstring

* Release 1.0.37

* chore(deps): update poetry-deps (#442)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#443)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.3 → v0.4.4](astral-sh/ruff-pre-commit@v0.4.3...v0.4.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Release 1.0.38

* fix push to pypi

* poetry update

* chore(deps): update dependency pyhelper-utils to ^0.0.17 (#444)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.39

* pypi: save dist dir as arg

* Release 1.0.40

* chore(deps): update dependency pyhelper-utils to ^0.0.18 (#445)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix when no jira issue label

* chore(deps): update dependency requests to v2.32.0 (#446)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency requests to v2.32.1 (#447)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.41

* set self.all_required_status_checks to [] in init

* chore(deps): update dependency requests to v2.32.2 (#449)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency pyhelper-utils to ^0.0.19 (#448)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#450)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.42

* chore(deps): update poetry-deps (#452)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency pyhelper-utils to ^0.0.20 (#451)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.43

* chore(deps): update poetry-deps (#454)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency pyhelper-utils to ^0.0.21 (#453)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.44

* [pre-commit.ci] pre-commit autoupdate (#455)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.4 → v0.4.5](astral-sh/ruff-pre-commit@v0.4.4...v0.4.5)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Release 1.0.45

* chore(deps): update poetry-deps (#457)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* update renovate.json

* chore(deps): update poetry-deps (#458)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#459)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#460)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* do not comment when unsuported label passed from the user

* push container: push from main branch if pull request was merged

* chore(deps): update poetry-deps (#461)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* build container: checkout the right branch if PR is merged (#462)

* build container: checkout the right branch if PR is merged

* no-cache for merged PRs

* Use uwsgi to run the app (#464)

* Use uwsgi to run the app

* Use uwsgi to run the app

* Use uwsgi to run the app

* Use uwsgi to run the app

* Use uwsgi to run the app

* [pre-commit.ci] pre-commit autoupdate (#466)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.5 → v0.4.7](astral-sh/ruff-pre-commit@v0.4.5...v0.4.7)
- [github.com/gitleaks/gitleaks: v8.18.2 → v8.18.3](gitleaks/gitleaks@v8.18.2...v8.18.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#467)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.46

* Fix upload to pypi

* Fix upload to pypi

* Fix upload to pypi

* Release 1.0.47

* remove unused function skip_repo

* Tox add unused-code check

* remove commented lines

* Release 1.0.48

* [pre-commit.ci] pre-commit autoupdate (#468)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.7 → v0.4.8](astral-sh/ruff-pre-commit@v0.4.7...v0.4.8)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Release 1.0.49

* Fix container release push

* chore(deps): update poetry-deps (#469)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update poetry

* update renovate file

* chore(deps): update poetry-deps (#471)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#472)

updates:
- [github.com/PyCQA/flake8: 7.0.0 → 7.1.0](PyCQA/flake8@7.0.0...7.1.0)
- [github.com/astral-sh/ruff-pre-commit: v0.4.8 → v0.4.9](astral-sh/ruff-pre-commit@v0.4.8...v0.4.9)
- [github.com/gitleaks/gitleaks: v8.18.3 → v8.18.4](gitleaks/gitleaks@v8.18.3...v8.18.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#473)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* log success when test run success (#474)

* Release 1.0.50

* chore(deps): update poetry-deps (#476)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#477)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* delete pr tag on merge/close of a pr (#478)

* delete pr tag on merge/close of a pr

* updates based on review comments

* fixing some commands

* determine registry url from container_repository value

* address review comment

* update based on comments received

* remove verify_stderr

* updates

* [pre-commit.ci] pre-commit autoupdate (#479)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.9 → v0.4.10](astral-sh/ruff-pre-commit@v0.4.9...v0.4.10)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Release 1.0.51

* remove sonarcload workflow

* Move to using FastAPI (#480)

* Move to using FastAPI

* update post function

* remove label module

* add missing host and port

* Fix request type

* remove uneeded code

* Fix logger calls

---------

Co-authored-by: rnetser <rnetser@redhat.com>

* delete_remote_tag_for_merged_or_closed_pr: run only when repo have container

* Fix delete pr cintainer tag when merged/closed

* Fix delete pr container tag when merged/closed

* Release 1.0.52

* support log file

* add some typing, fix delete tag

* chore(deps): update poetry-deps (#482)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.53

* Fix delete tag

* create webhhok: remove duplicate log

* [pre-commit.ci] pre-commit autoupdate (#483)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.10 → v0.5.0](astral-sh/ruff-pre-commit@v0.4.10...v0.5.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

* Add more typing

* Add future in branch protection (#484)

* Use future in branch protection

* fix arg

* fix arg

* unused

* unused remove

* update sleep

* chore(deps): update poetry-deps (#488)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.54

* Add Typing (#486)

* Add typing

* Add typing

* fix type

* remove DockerHub

* ad mypy

* update return type

* update return type

* More typing

* More typing

* More typing

* More typing

* More typing

* update return type

* update return type

* More typing

* More typing

* More typing

* Remove can be merged lable when check failed

* Fix call check_run process

* improve check if can be merged

* improve process pull request speed

* add pr number to log when check run reset to queued on startup

* pass log to get_future_results

* Fix delete tag for merged PR

* Set log warn when set check run to queued

* update poetry

* Fix add reviewers

* Fix add reviewers

* fix release for container

* fix release for container

* fix release for container

---------

Co-authored-by: Meni Yakove <myakove@gmail.com>

* Release 1.0.55

* move process to function (#490)

* move process to function

* improve can_be_mrged calls

* chore(deps): update poetry-deps (#489)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#492)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.0 → v0.5.1](astral-sh/ruff-pre-commit@v0.5.0...v0.5.1)
- [github.com/pre-commit/mirrors-mypy: v1.10.0 → v1.10.1](pre-commit/mirrors-mypy@v1.10.0...v1.10.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Add comment when reviewer failed to be added (#493)

* Add command arguments to the build-and-push-container (#495)

* Add command arguments to the build-and-push-container

* Podman fix

* chore(deps): update poetry-deps (#496)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#499)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.1 → v0.5.2](astral-sh/ruff-pre-commit@v0.5.1...v0.5.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Set approve label only if reviewer is part of approvers (#497)

* Set approve label only if reviewer is part of approvers

* Update the readme

* Add missing typing

* Fix missing {} in fstring

* Fix missing {} in fstring

* fix can be merged check

* Add support to pass log level

* Fix where is no last commiter in commit (#501)

* chore(deps): update poetry-deps (#500)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.56

* chore(deps): update poetry-deps (#505)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#506)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.2 → v0.5.4](astral-sh/ruff-pre-commit@v0.5.2...v0.5.4)
- [github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.11.0](pre-commit/mirrors-mypy@v1.10.1...v1.11.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* ProcessGithubWehook: do not use @ignore_exceptions (#503)

* ProcessGithubWehook: do not use @ignore_exceptions

* fail if any exeption in from process()

* remove @ignore_exceptions from all files

* fix some typing

* Improve logging (#507)

* Improve logging

* Add color to repository name in the log

* Add color to repository name in the log

* convert some logger info to debug

* convert some logger info to debug

* Function to get logger

* Function to get logger

* More logging debug

* log api rate only if below minimum

* More debug logs

* Use string-color for log_prefix

* Use string-color for log_prefix

* Use string-color for log_prefix

* Use string-color for log_prefix

* Use string-color for log_prefix

* Use string-color for log_prefix

* Use string-color for log_prefix

* Use string-color for log_prefix

* Use string-color for log_prefix

* always read config when creating logger to support switch levels without restart

* Try to fix log console colors

* Update example config

* set wip label based on title (#509)

* wip label - add missing f-string (#511)

* Release 1.0.57

* chore(deps): update poetry-deps (#513)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#514)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.58

* chore(deps): update poetry-deps (#515)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update tox configuration to run tests based on pull request parent branch

* Release 1.0.59

* chore(deps): update poetry-deps (#516)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix remove lgtm by on pr sync

* Set log file zise to 10mb

* [pre-commit.ci] pre-commit autoupdate (#517)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.4 → v0.5.5](astral-sh/ruff-pre-commit@v0.5.4...v0.5.5)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Extract some code to function (#518)

* Extract some code to function

* Improve error msg of build and push container command

* No limit log file size

* Log file zise set to 50MB

* fix check if user command supported

* fix check if user command supported

* Rename _process_verified to more clrean name

* log file, no size limi

* Improve no ready to merged output

* Use one logger for all

* Fix BUILD_AND_PUSH_CONTAINER_STR user command

* Fix BUILD_AND_PUSH_CONTAINER_STR user command

* Fix BUILD_AND_PUSH_CONTAINER_STR user command

* chore(deps): update poetry-deps (#520)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#522)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#523)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Extract to functions, run in parallel (#524)

* Extract to functions, run in parallel

* Extract to functions, run in parallel

* Extract to functions, run in parallel

* Remove time loggers

* [pre-commit.ci] pre-commit autoupdate (#526)

updates:
- [github.com/PyCQA/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
- [github.com/astral-sh/ruff-pre-commit: v0.5.5 → v0.5.6](astral-sh/ruff-pre-commit@v0.5.5...v0.5.6)
- [github.com/pre-commit/mirrors-mypy: v1.11.0 → v1.11.1](pre-commit/mirrors-mypy@v1.11.0...v1.11.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#527)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix mypy pre-commit types deps issues

* chore(deps): update poetry-deps (#528)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Remove unused code (#529)

* Release 1.0.60

* chore(deps): update poetry-deps (#531)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#532)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.6 → v0.5.7](astral-sh/ruff-pre-commit@v0.5.6...v0.5.7)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#533)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#534)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.61

* chore(deps): update poetry-deps (#535)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.62

* chore(deps): update poetry-deps (#536)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#538)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#537)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.7 → v0.6.1](astral-sh/ruff-pre-commit@v0.5.7...v0.6.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* run rm -rf /run/containers/storage /run/libpod on server start

* chore(deps): update poetry-deps (#539)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* add back k3d to the container

* Add docker to the container (#540)

* chore(deps): update poetry-deps (#542)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#543)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#544)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#545)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.1 → v0.6.2](astral-sh/ruff-pre-commit@v0.6.1...v0.6.2)
- [github.com/pre-commit/mirrors-mypy: v1.11.1 → v1.11.2](pre-commit/mirrors-mypy@v1.11.1...v1.11.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Release 1.0.63

* chore(deps): update poetry-deps (#546)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.64

* chore(deps): update poetry-deps (#547)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.65

* [pre-commit.ci] pre-commit autoupdate (#548)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.2 → v0.6.3](astral-sh/ruff-pre-commit@v0.6.2...v0.6.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#549)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#550)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#551)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#552)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.3 → v0.6.4](astral-sh/ruff-pre-commit@v0.6.3...v0.6.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#553)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#554)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#556)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#557)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Only approvers should be able to set `hold` lable on PR (#558)

* Release 1.0.66

* chore(deps): update poetry-deps (#560)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#561)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.4 → v0.6.5](astral-sh/ruff-pre-commit@v0.6.4...v0.6.5)
- [github.com/gitleaks/gitleaks: v8.18.4 → v8.19.2](gitleaks/gitleaks@v8.18.4...v8.19.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#562)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Release 1.0.67

* chore(deps): update poetry-deps (#563)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* update poetry

* chore(deps): update poetry-deps (#564)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(github_api): refactor size label calculation (#565)

* chore(deps): update poetry-deps (#567)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#569)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#568)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.5 → v0.6.7](astral-sh/ruff-pre-commit@v0.6.5...v0.6.7)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Add simple test for `get_size` (#570)

* Add simple test for `get_size`

* Add simple test for `get_size`

* fix type

* Fix config path for test when running inside container

* revert config path for tests

* add config.yaml for tests

* fix typo

* chore(deps): update poetry-deps (#572)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#573)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* remove k3d from dockerfile

* Set PR as auto-merge when commiter is part of auth-merged users (#574)

* fix pre-commit mypy exlude regex

* [pre-commit.ci] pre-commit autoupdate (#576)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.7 → v0.6.8](astral-sh/ruff-pre-commit@v0.6.7...v0.6.8)
- [github.com/gitleaks/gitleaks: v8.19.2 → v8.19.3](gitleaks/gitleaks@v8.19.2...v8.19.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Release 1.0.68

* chore(deps): update poetry-deps (#577)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update poetry-deps (#578)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#581)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/astral-sh/ruff-pre-commit: v0.6.8 → v0.6.9](astral-sh/ruff-pre-commit@v0.6.8...v0.6.9)
- [github.com/gitleaks/gitleaks: v8.19.3 → v8.20.1](gitleaks/gitleaks@v8.19.3...v8.20.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Run check if can be merged when hold label is add/removed (#582)

* check if pr is already set to auto merge before enable (#586)

* check if pr is already set to automerge before enable

* do not raise if label not exists in remove label

* set_pull_request_automerge: do not fail on exception

* use `uv` instead of `poetry` (#579)

* use `uv` only to manage project install and exeute

* Fix dockerfile PATH

* Fix dockerfile $PATH

* tox: use uv

* remove poetry.lock

* Add YAML $schema file

* Add YAML $schema file to example config

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Debarati Basu-Nag <dbasunag@redhat.com>
Co-authored-by: rnetser <rnetser@redhat.com>
Co-authored-by: Jenia Peimer <86722603+jpeimer@users.noreply.github.com>
@myakove myakove mentioned this pull request Apr 6, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants