Skip to content

Run check if can be merged when hold label is add/removed #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myakove merged 2 commits into from
Oct 8, 2024
Merged

Run check if can be merged when hold label is add/removed #582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b901c84
Run check if can be merged when hold label is add/removed
myakove Oct 8, 2024
176aa65
Merge branch 'main' of github.com:myk-org/github-webhook-server into …
myakove Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 2 additions & 62 deletions webhook_server_container/libs/github_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,36 +632,6 @@ def get_size(self) -> str:

return f"{SIZE_LABEL_PREFIX}XXL"

# def get_size(self) -> str:
# """Calculate size label based on additions and deletions."""
# size: int = self.pull_request.additions + self.pull_request.deletions
# if size < 20:
# _label = "XS"
#
# elif size < 50:
# _label = "S"
#
# elif size < 100:
# _label = "M"
#
# elif size < 300:
# _label = "L"
#
# elif size < 500:
# _label = "XL"
#
# else:
# _label = "XXL"
#
# return f"{SIZE_LABEL_PREFIX}{_label}"
# # size = self.pull_request.additions + self.pull_request.deletions
# # prefixes = ["XS", "S", "M", "L", "XL", "XXL"]
# # for prefix in prefixes:
# # if size < 20 * (prefix[:-1].upper() == "S") + 10:
# # return f"{SIZE_LABEL_PREFIX}{prefix}"
# #
# # return ""

def add_size_label(self) -> None:
"""Add a size label to the pull request based on its additions and deletions."""
size_label = self.get_size()
Expand All @@ -679,38 +649,6 @@ def add_size_label(self) -> None:

self._add_label(label=size_label)

# def add_size_label(self) -> None:
# size: int = self.pull_request.additions + self.pull_request.deletions
# if size < 20:
# _label = "XS"
#
# elif size < 50:
# _label = "S"
#
# elif size < 100:
# _label = "M"
#
# elif size < 300:
# _label = "L"
#
# elif size < 500:
# _label = "XL"
#
# else:
# _label = "XXL"
#
# size_label = f"{SIZE_LABEL_PREFIX}{_label}"
#
# if size_label in self.pull_request_labels_names():
# return
#
# exists_size_label = [label for label in self.pull_request_labels_names() if label.startswith(SIZE_LABEL_PREFIX)]
#
# if exists_size_label:
# self._remove_label(label=exists_size_label[0])
#
# self._add_label(label=size_label)

def label_by_user_comment(
self, user_requested_label: str, remove: bool, reviewed_user: str, issue_comment_id: int
) -> None:
Expand Down Expand Up @@ -1213,6 +1151,8 @@ def user_commands(self, command: str, reviewed_user: str, issue_comment_id: int)
else:
self._add_label(label=HOLD_LABEL_STR)

self.check_if_can_be_merged()

else:
self.label_by_user_comment(
user_requested_label=_command,
Expand Down