Skip to content

no need to decode if we have pipe argument for run_command call #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbasunag wants to merge 1 commit into from
Closed

no need to decode if we have pipe argument for run_command call #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions webhook_server_container/utils/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,12 @@ def run_command(
timeout=timeout,
**kwargs,
)
out_decoded = sub_process.stdout.decode() if isinstance(sub_process.stdout, bytes) else sub_process.stdout
err_decoded = sub_process.stderr.decode() if isinstance(sub_process.stderr, bytes) else sub_process.stderr
out_decoded = (
sub_process.stdout.decode() if isinstance(sub_process.stdout, bytes) and not pipe else sub_process.stdout
)
err_decoded = (
sub_process.stderr.decode() if isinstance(sub_process.stderr, bytes) and not pipe else sub_process.stderr
)

error_msg = (
f"{log_prefix} Failed to run '{command}'. "
Expand Down