Skip to content

Mark PR as approverd if number os reviewer is less then minimum lgtm #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myakove merged 1 commit into from
Apr 25, 2025
Merged

Mark PR as approverd if number os reviewer is less then minimum lgtm #727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions webhook_server_container/libs/github_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2131,11 +2131,19 @@ def _check_if_pr_approved(self, labels: list[str]) -> str:
error += f"Missing approved from approvers: {', '.join(missing_approvers)}\n"

if lgtm_count < self.minimum_lgtm:
all_reviewers = self.all_reviewers.copy()
if self.parent_committer in all_reviewers:
all_reviewers.pop(all_reviewers.index(self.parent_committer))
if lgtm_count == len(self.all_reviewers):
self.logger.debug(
f"{self.log_prefix} minimum_lgtm is {self.minimum_lgtm}, but number of reviewers is {len(self.all_reviewers)}. PR approved."
)
else:
all_reviewers = self.all_reviewers.copy()
if self.parent_committer in all_reviewers:
all_reviewers.pop(all_reviewers.index(self.parent_committer))

error += f"Missing lgtm from reviewers. Minimum {self.minimum_lgtm} required. Reviewers: {', '.join(all_reviewers)}.\n"
error += (
"Missing lgtm from reviewers. "
f"Minimum {self.minimum_lgtm} required. Reviewers: {', '.join(all_reviewers)}.\n"
)

return error

Expand Down