Skip to content

Return response to Github in time, run our process as BackgroundTasks #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myakove merged 2 commits into from
May 7, 2025
Merged

Return response to Github in time, run our process as BackgroundTasks #756

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75b81f2
Return respomse to Github in time, run our process as BackgroundTasks
myakove May 7, 2025
e99d6d0
handles exceptions in the background task
myakove May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions webhook_server/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import requests
import urllib3
from fastapi import (
BackgroundTasks,
Depends,
FastAPI,
HTTPException,
Expand Down Expand Up @@ -120,7 +121,7 @@ def healthcheck() -> dict[str, Any]:


@FASTAPI_APP.post(APP_URL_ROOT_PATH, dependencies=[Depends(gate_by_allowlist_ips)])
async def process_webhook(request: Request) -> dict[str, Any]:
async def process_webhook(request: Request, background_tasks: BackgroundTasks) -> dict[str, Any]:
logger_name: str = "main"
logger = get_logger_with_params(name=logger_name)

Expand Down Expand Up @@ -149,7 +150,14 @@ async def process_webhook(request: Request) -> dict[str, Any]:

try:
api: ProcessGithubWehook = ProcessGithubWehook(hook_data=hook_data, headers=request.headers, logger=logger)
await api.process()

async def process_with_error_handling() -> None:
try:
await api.process()
except Exception as e:
logger.exception(f"{log_context} Error in background task: {e}")

background_tasks.add_task(process_with_error_handling)
return {"status": requests.codes.ok, "message": "process success", "log_prefix": delivery_headers}

except RepositoryNotFoundError as e:
Expand Down