Skip to content

Include root_approvers lgtm when check if PR is ready for merge #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myakove merged 2 commits into from
May 10, 2025
Merged

Include root_approvers lgtm when check if PR is ready for merge #767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfcc59b
Include `root_approvers` lgtm when cheking if PR is ready for merge
myakove May 9, 2025
7f48cae
count also root_reviews
myakove May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions webhook_server/libs/github_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,7 +1262,7 @@ def check_if_can_be_merged(self) -> None:

try:
self.logger.info(f"{self.log_prefix} Check if {CAN_BE_MERGED_STR}.")
self.set_merge_check_queued()
self.set_merge_check_in_progress()
last_commit_check_runs = list(self.last_commit.get_check_runs())
_labels = self.pull_request_labels_names()
self.logger.debug(f"{self.log_prefix} check if can be merged. PR labels are: {_labels}")
Expand Down Expand Up @@ -1984,8 +1984,8 @@ def get_all_approvers(self) -> list[str]:
def get_all_reviewers(self) -> list[str]:
_reviewers: list[str] = []
for list_of_reviewers in self.owners_data_for_changed_files().values():
for _approver in list_of_reviewers.get("reviewers", []):
_reviewers.append(_approver)
for _reviewer in list_of_reviewers.get("reviewers", []):
_reviewers.append(_reviewer)

_reviewers.sort()
return _reviewers
Expand Down Expand Up @@ -2132,7 +2132,7 @@ def _check_if_pr_approved(self, labels: list[str]) -> str:
approved_by = []
lgtm_count: int = 0

all_reviewers = self.all_reviewers.copy()
all_reviewers = self.all_reviewers.copy() + self.root_approvers.copy() + self.root_reviewers.copy()
all_reviewers_without_pr_owner = {
_reviewer for _reviewer in all_reviewers if _reviewer != self.parent_committer
}
Expand Down