Skip to content

refactor: remove obvious comments that restate code logic #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myakove merged 1 commit into from
Jul 30, 2025
Merged

refactor: remove obvious comments that restate code logic #831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions webhook_server/libs/labels_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,11 @@ async def _add_label(self, pull_request: PullRequest, label: str) -> None:
self.logger.debug(f"{self.log_prefix} Label {label} already assign")
return

# Handle static labels first (includes default size labels)
if label in STATIC_LABELS_DICT:
self.logger.info(f"{self.log_prefix} Adding pull request label {label}")
await asyncio.to_thread(pull_request.add_to_labels, label)
return

# Determine color for the label
color = self._get_label_color(label)
_with_color_msg = f"repository label {label} with color {color}"

Expand Down Expand Up @@ -111,11 +109,9 @@ def _get_label_color(self, label: str) -> str:
For other dynamic labels, uses the DYNAMIC_LABELS_DICT.
Falls back to default color if not found.
"""
# Check if it's a custom size label
if label.startswith(SIZE_LABEL_PREFIX):
size_name = label[len(SIZE_LABEL_PREFIX) :]

# Get custom thresholds and find the color for this size
thresholds = self._get_custom_pr_size_thresholds()
for threshold, label_name, color_hex in thresholds:
if label_name == size_name:
Expand All @@ -126,12 +122,10 @@ def _get_label_color(self, label: str) -> str:
if label in STATIC_LABELS_DICT:
return STATIC_LABELS_DICT[label]

# Check dynamic labels dict for other label types
_color = [DYNAMIC_LABELS_DICT[_label] for _label in DYNAMIC_LABELS_DICT if _label in label]
if _color:
return _color[0]

# Default fallback color
return "D4C5F9"

def _get_color_hex(self, color_name: str, default_color: str = "lightgray") -> str:
Expand All @@ -157,7 +151,6 @@ def _get_custom_pr_size_thresholds(self) -> list[tuple[int | float, str, str]]:
custom_config = self.github_webhook.config.get_value("pr-size-thresholds", return_on_none=None)

if not custom_config:
# Return static defaults with their colors
return [
(20, "XS", "ededed"),
(50, "S", "0E8A16"),
Expand All @@ -167,7 +160,6 @@ def _get_custom_pr_size_thresholds(self) -> list[tuple[int | float, str, str]]:
(float("inf"), "XXL", "B60205"),
]

# Parse custom configuration
thresholds = []
for label_name, config in custom_config.items():
threshold = config.get("threshold")
Expand Down
3 changes: 0 additions & 3 deletions webhook_server/tests/test_labels_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ def test_get_size_none_additions(self, labels_handler: LabelsHandler) -> None:

result = labels_handler.get_size(pull_request=pull_request)

# Should handle None additions gracefully
assert result.startswith(SIZE_LABEL_PREFIX)

def test_get_size_none_deletions(self, labels_handler: LabelsHandler) -> None:
Expand All @@ -111,7 +110,6 @@ def test_get_size_none_deletions(self, labels_handler: LabelsHandler) -> None:

result = labels_handler.get_size(pull_request=pull_request)

# Should handle None deletions gracefully
assert result.startswith(SIZE_LABEL_PREFIX)

def test_get_size_both_none(self, labels_handler: LabelsHandler) -> None:
Expand All @@ -122,7 +120,6 @@ def test_get_size_both_none(self, labels_handler: LabelsHandler) -> None:

result = labels_handler.get_size(pull_request=pull_request)

# Should default to XS when both are None
assert result == f"{SIZE_LABEL_PREFIX}XS"

@pytest.mark.asyncio
Expand Down