Skip to content

feat: enable log-viewer only when os env ENABLE_LOG_SERVER=true #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myakove merged 3 commits into from
Aug 7, 2025
Merged

feat: enable log-viewer only when os env ENABLE_LOG_SERVER=true #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
575d432
feat: enable log-viewer only when os env ENABLE_LOG_SERVER=true
myakove Aug 7, 2025
0e6cfc6
Merge branch 'main' of github.com:myk-org/github-webhook-server into …
myakove Aug 7, 2025
74eb9f3
test: fix log server endpoint tests for conditional registration
myakove Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions webhook_server/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,11 +275,13 @@ def get_log_viewer_controller() -> LogViewerController:
controller_dependency = Depends(get_log_viewer_controller)


# Log Viewer Endpoints
@FASTAPI_APP.get("/logs", operation_id="get_log_viewer_page", response_class=HTMLResponse)
def get_log_viewer_page(controller: LogViewerController = controller_dependency) -> HTMLResponse:
"""Serve the main log viewer HTML page."""
return controller.get_log_page()
# Log Viewer Endpoints - Only register if ENABLE_LOG_SERVER=true
if os.environ.get("ENABLE_LOG_SERVER") == "true":

@FASTAPI_APP.get("/logs", operation_id="get_log_viewer_page", response_class=HTMLResponse)
def get_log_viewer_page(controller: LogViewerController = controller_dependency) -> HTMLResponse:
"""Serve the main log viewer HTML page."""
return controller.get_log_page()


async def _get_log_entries_core(
Expand Down
1 change: 1 addition & 0 deletions webhook_server/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from webhook_server.libs.owners_files_handler import OwnersFileHandler

os.environ["WEBHOOK_SERVER_DATA_DIR"] = "webhook_server/tests/manifests"
os.environ["ENABLE_LOG_SERVER"] = "true"
from webhook_server.libs.github_api import GithubWebhook


Expand Down
1 change: 1 addition & 0 deletions webhook_server/tests/test_log_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,7 @@ def test_get_logs_page(self) -> None:
from fastapi.responses import HTMLResponse

mock_instance.get_log_page.return_value = HTMLResponse(content="<html><body>Log Viewer</body></html>")
mock_instance.shutdown = AsyncMock() # Add async shutdown method

from webhook_server.app import FASTAPI_APP

Expand Down