Skip to content

fix: enhance conventional title validation to support scoped commits #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myakove merged 2 commits into from
Aug 13, 2025
Merged

fix: enhance conventional title validation to support scoped commits #848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
584367a
fix: enhance conventional title validation to support scoped commits
myakove Aug 13, 2025
3068efb
Merge branch 'main' of github.com:myk-org/github-webhook-server into …
myakove Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion webhook_server/libs/runner_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import asyncio
import contextlib
import re
import shutil
from typing import TYPE_CHECKING, Any, AsyncGenerator
from uuid import uuid4
Expand Down Expand Up @@ -444,8 +445,9 @@ async def run_conventional_title_check(self, pull_request: PullRequest) -> None:
await self.check_run_handler.set_conventional_title_in_progress()
allowed_names = self.github_webhook.conventional_title.split(",")
title = pull_request.title

self.logger.debug(f"{self.log_prefix} Conventional title check for title: {title}, allowed: {allowed_names}")
if any([title.startswith(f"{_name}:") for _name in allowed_names]):
if any([re.search(rf"{_name}(.*):", title) for _name in allowed_names]):
self.logger.step(f"{self.log_prefix} Conventional title check completed successfully") # type: ignore
await self.check_run_handler.set_conventional_title_success(output=output)
else:
Expand Down