Skip to content

feat(owners): add comprehensive debug logging for OWNERS file parsing #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myakove merged 1 commit into from
Nov 18, 2025
Merged

feat(owners): add comprehensive debug logging for OWNERS file parsing #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions webhook_server/libs/handlers/owners_files_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,30 @@ async def get_all_repository_approvers_and_reviewers(self) -> dict[str, dict[str
# Find all OWNERS files via filesystem walk
self.logger.debug(f"{self.log_prefix} Finding OWNERS files in local clone")

# Run both git commands in parallel (RULE #0)
git_branch_cmd = f"git -C {shlex.quote(str(clone_path))} branch --show-current"
git_log_cmd = f"git -C {shlex.quote(str(clone_path))} log -1 --format=%H%x20%s -- OWNERS"

branch_task = run_command(
command=git_branch_cmd,
log_prefix=self.log_prefix,
verify_stderr=False,
mask_sensitive=self.github_webhook.mask_sensitive,
)
log_task = run_command(
command=git_log_cmd,
log_prefix=self.log_prefix,
verify_stderr=False,
mask_sensitive=self.github_webhook.mask_sensitive,
)

(branch_success, current_branch, _), (log_success, log_output, _) = await asyncio.gather(branch_task, log_task)

if branch_success and current_branch.strip():
self.logger.debug(f"{self.log_prefix} Reading OWNERS files from branch: {current_branch.strip()}")
if log_success and log_output.strip():
self.logger.debug(f"{self.log_prefix} Latest OWNERS commit: {log_output.strip()}")

# Use rglob to recursively find all OWNERS files
def find_owners_files() -> list[Path]:
return [
Expand Down Expand Up @@ -250,8 +274,19 @@ def find_owners_files() -> list[Path]:
# At this point, result must be a tuple (file_content, relative_path_str)
file_content, relative_path_str = result

self.logger.debug(
f"{self.log_prefix} Raw OWNERS file for {relative_path_str}: "
f"{len(file_content)} bytes, {len(file_content.splitlines())} lines"
)

try:
content = yaml.safe_load(file_content)

self.logger.debug(
f"{self.log_prefix} Parsed OWNERS structure for {relative_path_str} - "
f"type: {type(content)}, keys: {list(content.keys()) if isinstance(content, dict) else 'N/A'}, "
f"content: {content}"
)
if self._validate_owners_content(content, relative_path_str):
parent_path = str(Path(relative_path_str).parent)
if not parent_path or parent_path == ".":
Expand Down