wip: v3 #318
Draft
wip: v3 #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
============================================
+ Coverage 96.68% 96.82% +0.14%
+ Complexity 1716 1699 -17
============================================
Files 319 318 -1
Lines 5820 5769 -51
============================================
- Hits 5627 5586 -41
+ Misses 193 183 -10 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
joerivanveen
approved these changes
Nov 8, 2024
EdieLemoine
force-pushed
the
v3
branch
6 times, most recently
from
97425f2 to
b53c367
Compare
BREAKING CHANGE: delete class \MyParcelNL\Pdk\Account\Repository\AbstractAccountRepository BREAKING CHANGE: delete class \MyParcelNL\Pdk\App\Api\PdkActions BREAKING CHANGE: delete class \MyParcelNL\Pdk\App\ShippingMethod\Repository\AbstractPdkShippingMethodRepository BREAKING CHANGE: delete class \MyParcelNL\Pdk\Settings\Repository\AbstractSettingsRepository BREAKING CHANGE: delete const \MyParcelNL\Pdk\Base\Contract\WeightServiceInterface::DIGITAL_STAMP_RANGES BREAKING CHANGE: delete interface \MyParcelNL\Pdk\Account\Contract\AccountRepositoryInterface BREAKING CHANGE: delete interface \MyParcelNL\Pdk\Settings\Contract\SettingsRepositoryInterface BREAKING CHANGE: delete method \MyParcelNL\Pdk\App\Installer\Contract\MigrationServiceInterface::all() BREAKING CHANGE: delete property \MyParcelNL\Pdk\Account\Model\Shop::$carrierOptions BREAKING CHANGE: delete property \MyParcelNL\Pdk\App\Order\Model\PdkOrder::$customsDeclaration BREAKING CHANGE: delete property \MyParcelNL\Pdk\App\Order\Model\PdkOrder::$orderLines BREAKING CHANGE: delete property \MyParcelNL\Pdk\App\Order\Model\PdkOrder::$orderNotes BREAKING CHANGE: delete property \MyParcelNL\Pdk\App\Order\Model\PdkOrder::$recipient BREAKING CHANGE: delete property \MyParcelNL\Pdk\App\ShippingMethod\Model\PdkShippingMethod::$allowPackageTypes BREAKING CHANGE: delete property \MyParcelNL\Pdk\App\ShippingMethod\Model\PdkShippingMethod::$allowPackageTypes BREAKING CHANGE: delete property \MyParcelNL\Pdk\Base\Model\Address::$fullStreet BREAKING CHANGE: delete property \MyParcelNL\Pdk\Base\Model\Address::$streetAdditionalInfo BREAKING CHANGE: delete property \MyParcelNL\Pdk\Carrier\Model\Carrier::$subscriptionId BREAKING CHANGE: delete trait \MyParcelNL\Pdk\Carrier\Concern\HasDeprecatedSubscriptionId BREAKING CHANGE: remove default implementation of getLogFiles in \MyParcelNL\Pdk\Logger\AbstractLogger BREAKING CHANGE: replace \Psr\Log\LoggerInterface with \MyParcelNL\Pdk\Logger\Contract\PdkLoggerInterface
FreekVR
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Is alleen voor nakijken en checks, mag niet gesquashed worden.)