Detect when Parliament data hasn't arrived and warn #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it's Tuesday to Saturday and it doesn't look like there are any files from Parliament then check if it's a recess and if not spit out a message. This should hopefully avoid sending out alerts when we've not received any files from Parliament
Member
|
Don't want to scope creep, but could this feed into the front-end display of recess dates in the calendars? :) |
Member
Author
|
Yup, I figure that's the next step. |
dracos
force-pushed
the
master
branch
8 times, most recently
from
1d3f86c to
daf097f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a warning to
process_hansard.pywhen it looks like we've failed to download files from Parliament. As part of this there's a script to fetch and save recess dates from Parliament which are then used to determine if we should expect any data.