Remove Link Previews#340
Conversation
Currently translated at 100.0% (173 of 173 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/fr/
Currently translated at 39.3% (68 of 173 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/tr/
Currently translated at 39.3% (68 of 173 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/tr/
Currently translated at 100.0% (173 of 173 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ru/
Currently translated at 100.0% (174 of 174 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ja/
Currently translated at 100.0% (174 of 174 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/fr/
|
Warning Rate limit exceeded@n-ce has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 44 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughRemoved the Netlify Edge Function Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User
participant N as Netlify Edge
participant S as Site/App
rect rgba(200,220,255,0.25)
note over N: Old flow (before)
U->>N: HTTP Request
N->>N: linkPreview Edge Function executes
N->>S: Forward (context.next)
S-->>N: Response
N->>N: Augment response (fetch YouTube data)
N-->>U: Modified HTML
end
rect rgba(220,200,200,0.25)
note over N: New flow (after)
U->>N: HTTP Request
N->>S: Direct forward (no linkPreview)
S-->>N: Response
N-->>U: Unmodified response
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Translations update from Hosted Weblate
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/stylesheets/list.css (1)
62-77: Consider dropping unnecessary !important flags in this block.Because this block appears after .reserved and has equal specificity, cascade should win without !important. This reduces specificity wars.
Apply if manual QA confirms no regressions:
li { - display: block !important; + display: block; } #deleteCollectionBtn, #renameCollectionBtn, #radioCollectionBtn, #importListBtn, #subscribeListBtn, #viewOnYTBtn { - display: none !important; + display: none; }src/lib/libraryUtils.ts (1)
133-143: Simplify class toggling with classList.toggle to avoid custom helper.Current helper works but is verbose. Toggle both flags in-place for clarity and fewer DOM reads.
Apply this diff:
-function exceptions(idx: string) { - if (listBtnsContainer.classList.contains(idx)) { - if (id !== idx) - listBtnsContainer.classList.remove(idx); - } - else if (id === idx) - listBtnsContainer.classList.add(idx); -} -exceptions('favorites'); -exceptions('listenLater'); +['favorites', 'listenLater'].forEach(cls => { + listBtnsContainer.classList.toggle(cls, id === cls); +});
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
src/lib/libraryUtils.ts(1 hunks)src/stylesheets/list.css(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/lib/libraryUtils.ts (1)
src/lib/dom.ts (1)
listBtnsContainer(35-35)
🔇 Additional comments (3)
src/stylesheets/list.css (2)
62-63: Extending reserved-style to listenLater is correct and consistent with TS changes.Selector now covers both .favorites and .listenLater, matching the new class toggling in fetchCollection.
120-120: Trailing newline added—good.Keeps POSIX tooling happy and avoids spurious diffs later.
src/lib/libraryUtils.ts (1)
133-143: No dangling references to removed Netlify Edge Function
Ran repository-wide searches forlinkPreviewimports,/edge-functions/routes, and Netlify config in.tomlfiles—found no matches. Edge function removal appears clean.
Summary by CodeRabbit
Chores
Bug Fixes / Improvements
Style