Skip to content

Revert "Reinstate fallback and update russian translation"#343

Merged
n-ce merged 1 commit into
mainfrom
revert-342-Reinstate-fallback
Sep 7, 2025
Merged

Revert "Reinstate fallback and update russian translation"#343
n-ce merged 1 commit into
mainfrom
revert-342-Reinstate-fallback

Conversation

@n-ce
Copy link
Copy Markdown
Owner

@n-ce n-ce commented Sep 7, 2025

This reverts commit 6f0d654.

Summary by CodeRabbit

  • Chores
    • Removed the legacy fallback streaming endpoint; the /streams/:id route is no longer served, and aggregated fallback stream metadata will not be returned. Users may see fewer or no fallback options for certain streams.
    • Cleaned up localization by removing an unused Russian translation entry for the JioSaavn preference setting.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Removes the Netlify Edge Function at netlify/edge-functions/fallback.ts, eliminating its route handler, config, and helper utilities. Also deletes the settings_jiosaavn key from src/locales/ru.json. No other files or logic are modified.

Changes

Cohort / File(s) Summary of Changes
Edge Function Removal
netlify/edge-functions/fallback.ts
Deleted the Edge Function handling /streams/:id, including default handler, config, fetcher, and shuffle.
Locales Update
src/locales/ru.json
Removed settings_jiosaavn translation entry; other entries unchanged.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant C as Client
    participant N as Netlify Edge (fallback.ts)
    participant R as RapidAPI

    Note over C,N: Previous flow (before removal)
    C->>N: GET /streams/:id
    N->>R: Fetch stream metadata (with rotated keys)
    R-->>N: Metadata/adaptiveFormats
    N-->>C: JSON (audioStreams, videoStreams, etc.)
Loading
sequenceDiagram
    autonumber
    participant C as Client
    participant N as Netlify Edge
    participant B as Backend/App

    Note over C,N: New flow (after removal)
    C->>N: GET /streams/:id
    N-->>C: No fallback.ts handler (route unhandled)
    opt Alternative handling
        C->>B: App-defined route or returns 404
        B-->>C: Response
    end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Maintainence Update #325 — Touches the same fallback Edge Function, altering env handling; directly related to its removal here.
  • Reinstate fallback #342 — Reintroduces the deleted fallback.ts and exports; directly conflicts with this deletion.

Poem

A rabbit hopped to prune a track,
The edge-path gone, no turning back.
Keys once shuffled, streams once spun,
Now silence where requests would run.
In Russian fields a line’s withdrawn—
Lighter packs, and onward, hop along! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f0d654 and 1db5b8e.

📒 Files selected for processing (2)
  • netlify/edge-functions/fallback.ts (0 hunks)
  • src/locales/ru.json (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-342-Reinstate-fallback

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@n-ce n-ce merged commit 6ab5908 into main Sep 7, 2025
1 of 2 checks passed
@n-ce n-ce deleted the revert-342-Reinstate-fallback branch September 7, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant