This repository was archived by the owner on Nov 10, 2017. It is now read-only.
Show error if phantomjs failed#12
Closed
dhamaniasad wants to merge 2 commits inton1k0:small-fixesfrom
Closed
Conversation
Owner
|
That would break the JSON output sent by the phantomjs script. You could add the |
Author
|
@n1k0 I was trying to use readable-proxy, and I got the "Unable to access" error for every single URL I tried. The web interface was displaying a blank alert, and adding the console.log made it show the error instead. I don't know much JS, and digging through the code, I can't figure out what's causing this. I've added the status value though. |
Owner
|
We've bumped the version of PhantomJS used in this project and it's very likely that this behavior has improved. Feel free to reopen if you still encounter the problem you had initially with the latest version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.