[WIP] EIP roles#9
Closed
scothis wants to merge 6 commits into
Closed
Conversation
- remove Subscribeable interface - Source now requires a Channel ObjectRef - cleanup language arround the role of a Source
remove reference that Source has subscriptions
Adding some clarification on 1:1 Source/Channel
matzew
reviewed
Oct 16, 2018
|
|
||
| ### Life Cycle | ||
|
|
||
| <<<<<<< HEAD |
n3wscott
reviewed
Oct 16, 2018
| | provisioner\* | ProvisionerReference | The provisioner used to create any backing resources and configuration. | Immutable. | | ||
| | arguments | runtime.RawExtension (JSON object) | Arguments passed to the provisioner for this specific source. | Arguments must validate against provisioner's parameters. | | ||
| | channel | ObjectRef | Specify an existing channel to use to emit events. If empty, create a new Channel using the cluster/namespace default. | Source will not emit events until channel exists. | | ||
| | channel\* | ObjectRef | Specify a Channel to target. | Source will not emit events until channel exists. | |
n3wscott
reviewed
Oct 16, 2018
|
|
||
| ### ChannelSubscriberSpec | ||
|
|
||
| <<<<<<< HEAD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Enterprise Integration Pattern roles
Builds on top of #4 for convince, but can be decoupled.