Skip to content

Render Left Accessory#102

Merged
n4kz merged 2 commits inton4kz:masterfrom
AlexisLeon:master
Oct 9, 2019
Merged

Render Left Accessory#102
n4kz merged 2 commits inton4kz:masterfrom
AlexisLeon:master

Conversation

@AlexisLeon
Copy link
Copy Markdown
Contributor

No description provided.

@cosmocoder
Copy link
Copy Markdown

@n4kz can you please merge this pull request, it is very a useful addition and will help a lot!

@hirthbrian
Copy link
Copy Markdown

Any update @n4kz? This would simplify a lot things on my side.

@petrogad
Copy link
Copy Markdown

petrogad commented Sep 14, 2018

@AlexisLeon would you mind making this PR against a maintained version of this project, https://www.npmjs.com/package/react-native-materialui-textfield?

@jackphuongvu
Copy link
Copy Markdown

Hi guys,

  • I'm looking for the solution to render left/right Accessory ... like this image.
    image
    Do you have any ideas with it?
  • Currently for now, renderLeftAccessory just works when I focus on this Text Input field?
    Thanks for having a look.

ceonelson added a commit to ceonelson/react-native-materialui-textfield that referenced this pull request Jun 18, 2019
@whalemare
Copy link
Copy Markdown

@n4kz please, we really need this feature.

@n4kz n4kz merged commit 4180945 into n4kz:master Oct 9, 2019
@n4kz
Copy link
Copy Markdown
Owner

n4kz commented Oct 9, 2019

Thanks for PR and sorry for delayed merge. I'll try to make a new release as soon as possible.

@n4kz
Copy link
Copy Markdown
Owner

n4kz commented Oct 9, 2019

I've renamed renderAccessory to renderRightAccessory for consistency and removed animation. In my opinion animation for accessories should be done in child components, so I've passed active and focused props to render callbacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants