DS Module Error Checks Comments/Questions

[hewanadun]

A1D:

• a1d-dsivp-p-1004, a1d-dsfvp-p-1004 => Change to If DSHRT = 0, DSAGEHRT should be 888, 999 (to prevent users entering an unaccepted value, for example with current check 120 would be accepted as a valid value)
• Need a similar plausibility check for DSYRSHRT in both IVP and FVP => If DSHRT = 0, DSYRSHRT should be 9

B1D: (Fix all versions i.e. V3 & V4 - IVP & FVP when applicable - error code may be different from what is mentioned below in other files):

• b1d-dsivp-p-1002: DSDISLEV => this checks for DSDISLEV = 0, but allowed values for DSDISLEV is 1-6 or 9
• b1d-dsivp-m-049: DSDXHS_MCI => since 0 is allowed for DSDXHS_MCI, change this check to If DSDXHS_NO = 1, DSDXHS_MCI cannot be 1
• Same as above for b1d-dsivp-m-051: DSDXHS_DEM
• b1d-dsivp-m-068: DSDXBY, b1d-dsivp-m-073: DSONSTMO, b1d-dsivp-m-076: DSONSTYR, b1d-dsivp-m-080: DSDEMCOM
  Modify above checks to allow 0 for DSDXHS_MCI and DSDXHS_DEM in the check (or change the check to If DSDXHS_NO = 1, then <var name> must be blank)
• b1d-dsivp-p-1008: DSDEP => full_desc does not match with the check
• b1d-dsfvp-p-1024: DSDXHS_MCI => typo in short_desc (either DSDXHS_MCI or DSDXHS_DEM should equal 1)
• b1d-dsfvp-p-1027: DSDEMMO => typo in test name (should be DSDEMMO)
• b1d-dsivp-m-072: short_desc should be "If DSDXBY ne 6"
• b1d-dsivp-c-019: Should be missingness, not conformity check
• b1d-dsivp-m-018 and b1d-dsivp-c-019: DSDXOTHX misspelled in most columns

D1D

• For DSHEADCM (777) and DSCHROM (7) do we need plausibility checks to validate whether a valid value entered at prev_visit?

We also need form header checks and pre-processing checks for DS module.

[hewanadun]

@kgauthreaux @jculhane
Please see above comments/questions about DS module error checks.

[jculhane]

@hewanadun See #500 for A1D, B1D, and D1D revisions.

@kgauthreaux It looks like you already created the header var checks - can you upload those and add any needed pre-processing checks?

[kgauthreaux]

@jculhane yes I can upload the header checks! @hewanadun I honestly just follow your lead on pre-processing. Not sure what you need for DS module. Should I just add it to the list of modules for any checks that include LBD and FTLD?

[hewanadun]

@jculhane yes I can upload the header checks! @hewanadun I honestly just follow your lead on pre-processing. Not sure what you need for DS module. Should I just add it to the list of modules for any checks that include LBD and FTLD?

Yes, if DS need the same checks as LBD and FTLD, please add it to the list of modules. The first check preprocess-001 is applicable to any module.